chore(clerk-js): Deprecate FormControl#1912
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b59249e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
elef/SDK-674-form-control-provider
branch
from
October 18, 2023 10:55
fd3d8b7 to
bddf7ad
Compare
desiprisg
reviewed
Oct 25, 2023
| LabelRow: FieldLabelRow, | ||
| Input: InputElement, | ||
| Action: FieldAction, | ||
| AsOptional: FieldOptionalLabel, |
Contributor
There was a problem hiding this comment.
Maybe rename this to OptionalLabel ?
anagstef
reviewed
Oct 25, 2023
anagstef
reviewed
Oct 25, 2023
anagstef
reviewed
Oct 25, 2023
anagstef
reviewed
Oct 25, 2023
anagstef
reviewed
Oct 25, 2023
anagstef
suggested changes
Oct 25, 2023
anagstef
left a comment
Contributor
There was a problem hiding this comment.
@panteliselef great stuff! just commit the changes we talked about and it's good to go.
panteliselef
force-pushed
the
elef/SDK-674-form-control-provider
branch
4 times, most recently
from
October 26, 2023 18:35
3964035 to
c7f4085
Compare
panteliselef
force-pushed
the
elef/SDK-674-form-control-provider
branch
from
October 30, 2023 19:08
c7f4085 to
7318421
Compare
panteliselef
added this pull request to the merge queue
Oct 30, 2023
panteliselef
removed this pull request from the merge queue due to a manual request
Oct 30, 2023
panteliselef
force-pushed
the
elef/SDK-674-form-control-provider
branch
from
October 31, 2023 10:56
7318421 to
e8a36d1
Compare
dimkl
reviewed
Oct 31, 2023
dimkl
left a comment
Contributor
There was a problem hiding this comment.
Let's add the deprecation of the FormControl in the main-v4 branch and open a clean-up PR from the main.
desiprisg
approved these changes
Oct 31, 2023
| * Stand-alone express middlewares bound to the pre-initialised clerkClient | ||
| */ | ||
| export const ClerkExpressRequireAuth = (...args: any) => { | ||
| export const ClerkExpressRequireAuth = (...args: Parameters<ReturnType<typeof createClerkExpressRequireAuth>>) => { |
Contributor
There was a problem hiding this comment.
Is this meant to be in this PR?
Contributor
There was a problem hiding this comment.
no! Should be dropped from this PR
Contributor
Author
There was a problem hiding this comment.
This is now dropped 🔥
panteliselef
force-pushed
the
elef/SDK-674-form-control-provider
branch
from
October 31, 2023 17:07
e8a36d1 to
b59249e
Compare
panteliselef
added this pull request to the merge queue
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is PR starts the refactoring process for our forms. The main focus is refactoring how our fields are structure, starting the
PlainInputwhich represents a simple input element.In the immediate feature we want to completely drop Form.Control and offer these alternatives
Their API will remain simple and those will be opinionated about the UI they represent, the underlying implementation will allow for easy changes tho.
fieldprefix in order to clearly indicate that the internal state reflects to a field not the entire formFormFieldContextProviderreplacesFormControlContextProvider(both need to co-exist until the refactor is complete)Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore