Skip to content

feat(clerk-js,types): Enable avatar shimmer by default#1972

Merged
LekoArts merged 3 commits into
mainfrom
vaggelis/sdk-638-enable-avatar-shimmer-effect-by-default
Oct 30, 2023
Merged

feat(clerk-js,types): Enable avatar shimmer by default#1972
LekoArts merged 3 commits into
mainfrom
vaggelis/sdk-638-enable-avatar-shimmer-effect-by-default

Conversation

@octoper

@octoper octoper commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Description

This PR enables the avatar shimmer by default for <UserButton/> and <OrganizationSwitcher/>.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot

changeset-bot Bot commented Oct 30, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d2cbdd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review October 30, 2023 12:25

@nikosdouvlis nikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @octoper - please add a changeset and merge once CICD runs.

@octoper
octoper added this pull request to the merge queue Oct 30, 2023
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2023
@LekoArts
LekoArts added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 41ae1d2 Oct 30, 2023
@LekoArts
LekoArts deleted the vaggelis/sdk-638-enable-avatar-shimmer-effect-by-default branch October 30, 2023 15:13
tmilewski pushed a commit that referenced this pull request Nov 17, 2023
* feat(clerk-js): Enable avatar shimmer by default

* feat(types): Enable avatar shimmer by default

* chore(repo): Add Changeset
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants