-
Notifications
You must be signed in to change notification settings - Fork 461
fix(shared): Remove "sideEffects" and fix postbuild script #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c1e0279
fix(clerk-expo,shared): Bundle shared in expo
LekoArts 140fc81
Revert "fix(clerk-expo,shared): Bundle shared in expo"
LekoArts 3629b5d
fix(shared): Add files key and fix script
LekoArts e938dd0
chore(repo): Linting
LekoArts 81a51e7
fix(shared): Add package.json to exports
LekoArts 26d72e7
Merge branch 'main' into fix/bundle-shared-in-expo
LekoArts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/shared': patch | ||
| --- | ||
|
|
||
| Remove `"sideEffects": "false"` since the package has side-effects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,27 @@ | |
| "name": "@clerk/shared", | ||
| "version": "1.0.0", | ||
| "description": "Internal package utils used by the Clerk SDKs", | ||
| "sideEffects": false, | ||
| "files": [ | ||
| "dist" | ||
| "dist", | ||
| "browser", | ||
| "callWithRetry", | ||
| "color", | ||
| "cookie", | ||
| "date", | ||
| "deprecated", | ||
| "error", | ||
| "file", | ||
| "globs", | ||
| "handleValueOrFn", | ||
| "isomorphicAtob", | ||
| "keys", | ||
| "loadScript", | ||
| "localStorageBroadcastChannel", | ||
| "poller", | ||
| "proxy", | ||
| "underscore", | ||
| "url", | ||
| "react" | ||
|
Comment on lines
+7
to
+25
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ @LekoArts why are these added at top level ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @panteliselef Please see #1950 |
||
| ], | ||
| "main": "./dist/index.js", | ||
| "exports": { | ||
|
|
@@ -37,7 +55,8 @@ | |
| "types": "./dist/react/index.d.ts", | ||
| "default": "./dist/react/index.js" | ||
| } | ||
| } | ||
| }, | ||
| "./package.json": "./package.json" | ||
| }, | ||
| "scripts": { | ||
| "build": "tsup", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you notice any side-effects (pun intended) in regards to code pruning when removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still all worked fine during bundling :)