Skip to content

refactor(types): Simplify WithOptions type generic#1995

Merged
LekoArts merged 1 commit into
mainfrom
refactor/simplify-withoptions-generic
Nov 1, 2023
Merged

refactor(types): Simplify WithOptions type generic#1995
LekoArts merged 1 commit into
mainfrom
refactor/simplify-withoptions-generic

Conversation

@tmilewski

Copy link
Copy Markdown
Member

Description

Simplifies the WithOptions generic by providing defaults to the generic.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski
tmilewski requested a review from a team November 1, 2023 00:59
@tmilewski tmilewski self-assigned this Nov 1, 2023
@changeset-bot

changeset-bot Bot commented Nov 1, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5c1c6e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/types Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg desiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef panteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee

@LekoArts
LekoArts added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 48ca40a Nov 1, 2023
@LekoArts
LekoArts deleted the refactor/simplify-withoptions-generic branch November 1, 2023 08:48
@dimkl

dimkl commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

🚀 nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants