Skip to content

chore(nextjs): Drop deprecations #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimkl merged 13 commits into from
Nov 3, 2023
Merged

chore(nextjs): Drop deprecations #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dfcb90b
chore(nextjs): Drop `app-beta` subpath import
dimkl Oct 31, 2023
7393f7e
chore(nextjs): Drop `*MagicLink*` related exports
dimkl Oct 31, 2023
ced9d8d
chore(nextjs): Drop `NEXT_PUBLIC_CLERK_FRONTEND_API` and `frontendApi`
dimkl Oct 31, 2023
0326799
chore(nextjs): Drop `ssr` subpath import
dimkl Nov 1, 2023
d9e999e
chore(nextjs): Drop `edge-middleware` subpath import
dimkl Nov 1, 2023
0c36690
chore(nextjs): Drop `CLERK_JS_VERSION`
dimkl Nov 1, 2023
08b9373
chore(nextjs): Drop `CLERK_API_KEY` and `apiKey`
dimkl Nov 1, 2023
2d4612e
chore(nextjs): Refactor to use `isDevelopmentFromApiKey` from `@cler…
dimkl Nov 1, 2023
6cfd6f6
chore(nextjs): Drop `withClerkMiddleware`
dimkl Nov 1, 2023
bda4364
chore(nextjs): Drop constants from exports
dimkl Nov 1, 2023
4fe6c24
chore(nextjs): Drop `api` subpath import
dimkl Nov 1, 2023
d676661
chore(nextjs): Drop unused `@clerk/clerk-sdk-node` dependency
dimkl Nov 2, 2023
a47baa2
chore(nextjs): Add changeset
dimkl Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .changeset/cyan-stingrays-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
'@clerk/nextjs': major
---

Drop deprecations. Migration steps:

@anagstef anagstef Nov 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimkl Should we mark these as breaking?

@dimkl dimkl Nov 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the major version bump should indicate that but we can also mark them as breaking changes. All the changes with major version are breaking. What do you think?

@dimkl dimkl Nov 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this to continue with the cleanup and i will update the changeset if we want to somehow mark the changes as breaking.

- use `NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY` instead of `NEXT_PUBLIC_CLERK_FRONTEND_API` env variable
- use `NEXT_PUBLIC_CLERK_JS_VERSION` instead of `CLERK_JS_VERSION`
- use `CLERK_SECRET_KEY` instead of `CLERK_API_KEY`
- use `publishableKey` instead of `frontendApi`
- use `isEmailLinkError` instead of `isMagicLinkError`
- use `EmailLinkErrorCode` instead of `MagicLinkErrorCode`
- use `useEmailLink` instead of `useMagicLink`
- use `@clerk/nextjs` instead of `@clerk/nextjs/app-beta`
- use `@clerk/nextjs` instead of `@clerk/nextjs/ssr`
- use `@clerk/nextjs` instead of `@clerk/nextjs/edge-middleware` or `@clerk/nextjs/edge-middlewarefiles`
- use `@clerk/nextjs` instead of `@clerk/nextjs/api`
- use middleware with `authMiddleware` instead of `withClerkMiddleware`
- avoid using exported constants: `API_URL`, `API_VERSION`, `CLERK_JS_URL`, `CLERK_JS_VERSION`, `DOMAIN`, `IS_SATELLITE`, `PROXY_URL`, `PUBLISHABLE_KEY`, `SECRET_KEY`, `SIGN_IN_URL`, `SIGN_UP_URL`
Loading