Skip to content

fix(clerk-js): Re-initialize Client singleton instance on Client destroy (#1913)#2016

Merged
octoper merged 1 commit into
release/v4from
backport-release/v4-1913
Nov 2, 2023
Merged

fix(clerk-js): Re-initialize Client singleton instance on Client destroy (#1913)#2016
octoper merged 1 commit into
release/v4from
backport-release/v4-1913

Conversation

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Backporting #1913 to the release/v4 branch

(cherry picked from commit 93a6115)

@changeset-bot

changeset-bot Bot commented Nov 2, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f71cd6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
octoper requested a review from a team November 2, 2023 13:26
@octoper

octoper commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator Author

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 0.4.14-snapshot.v14f8eac
@clerk/clerk-js 4.64.3-snapshot.v14f8eac
@clerk/clerk-expo 0.19.16-snapshot.v14f8eac

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@0.4.14-snapshot.v14f8eac --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.64.3-snapshot.v14f8eac --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.16-snapshot.v14f8eac --save-exact

…roy (#1913)

* fix(clerk-js): Re-initialize Client singleton on Client destroy

* fix(clerk-js): Assign default values instead of re-initializing Client class

* chore(repo): Adds changeset

* chore(repo): Adds changeset

* chore(clerk-js): Fix typo in test

* test(clerk-js): Added test for Client singleton destroy

* test(clerk-js): Update tests for Client singleton

* test(clerk-js): Update tests for Client singleton & created new fixtures

(cherry picked from commit 93a6115)
@octoper
octoper force-pushed the backport-release/v4-1913 branch from 14f8eac to f71cd6f Compare November 2, 2023 14:26
@octoper
octoper added this pull request to the merge queue Nov 2, 2023
Merged via the queue into release/v4 with commit 8ff6bef Nov 2, 2023
@octoper
octoper deleted the backport-release/v4-1913 branch November 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants