feat(clerk-js): Handle user_locked error during oauth flow with redir…#2019
Merged
Conversation
🦋 Changeset detectedLatest commit: 9dd106a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yourtallness
force-pushed
the
yourtallness/handle_oauth_user_locked
branch
from
November 2, 2023 16:35
ac95ef6 to
69b011a
Compare
panteliselef
approved these changes
Nov 3, 2023
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
Shall we add a test for displaying the error in SignUpStart ?
Contributor
|
@yourtallness is this something we need to backport to v4 ? |
Contributor
Author
This is pre-existing behaviour, but I'll take a look. |
Contributor
Author
@SokratisVidros @nikosdouvlis WDYT? |
…ect to /sign-up or /sign-in
yourtallness
force-pushed
the
yourtallness/handle_oauth_user_locked
branch
from
November 7, 2023 11:41
69b011a to
9dd106a
Compare
yourtallness
added this pull request to the merge queue
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ect to /sign-up or /sign-in
Description
When an oauth flow is started while a user is locked, we will get a
user_lockederror.The user will be identified, but after discussing with @desiprisg, we decided to redirect to
/sign-upor/sign-inso that theSignUporSignInare reset.We currently cannot offer the best UX from
/sign-in/factor-onebecause the oauth identification does not display nicely in the<IdentityPreview />component (the identifier is null).Thus for now we opted to restart the flow at step 1.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore