chore(clerk-sdk-node): Drop deprecations#2021
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8148ca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Blocked by #2006 |
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
5 times, most recently
from
November 3, 2023 15:00
ae6352e to
56b4880
Compare
panteliselef
reviewed
Nov 3, 2023
| ], | ||
| "scripts": { | ||
| "build": "npm run clean && tsup", | ||
| "postbuild": "node ../../scripts/subpath-workaround.mjs sdk-node", |
Contributor
There was a problem hiding this comment.
@dimkl probably i'm missing some context, but why do we need this ? feel free to point me to an internal document if necessary.
Contributor
Author
There was a problem hiding this comment.
This will generate a packages/sdk-node/instance/ folder with a package.json to be used for subpath import of @clerk/clerk-sdk-node/instance. We have used it in @clerk/shared.
LekoArts
previously requested changes
Nov 6, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
from
November 6, 2023 11:00
56b4880 to
7f9ed77
Compare
dimkl
commented
Nov 6, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
5 times, most recently
from
November 6, 2023 14:41
1431f76 to
7abf631
Compare
Merged
24 tasks
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
from
November 7, 2023 10:45
7abf631 to
6abb21b
Compare
The dropped setters: `setClerkApiVersion`, `setClerkHttpOptions`, `setClerkServerApiUrl`
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
from
November 7, 2023 11:04
6abb21b to
96a48a0
Compare
dimkl
enabled auto-merge
November 7, 2023 11:04
nikosdouvlis
reviewed
Nov 7, 2023
nikosdouvlis
approved these changes
Nov 7, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
from
November 7, 2023 11:42
96a48a0 to
915c067
Compare
Changes: - drop subpath exports of /esm|cjs/instance
dimkl
force-pushed
the
sdk-782-drop-deprecations-sdk-node
branch
from
November 7, 2023 11:44
915c067 to
8148ca3
Compare
nikosdouvlis
dismissed
LekoArts’s stale review
November 7, 2023 11:57
Dismissing the "request changes" review as it's blocking Dimitris. I've confirmed that the requested changes have been made.
dimkl
added this pull request to the merge queue
Nov 7, 2023
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop deprecations. Migration steps:
CLERK_SECRET_KEYinstead ofCLERK_API_KEYenv variablesecretKeyinstead ofapiKeyCLERK_PUBLISHABLE_KEYinstead ofCLERK_FRONTEND_APIenv variablepublishableKeyinstead offrontendApicreateClerkClientwith options to create a new clerkClient instead of usingthe following setters:
setClerkApiVersionsetClerkHttpOptionssetClerkServerApiUrlsetClerkApiKey@clerk/clerk-sdk-nodeinstead of@clerk/clerk-sdk-node/{cjs|esm}/instanceExtra:
Depends on the following PRs because of re-exports:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore