chore(types): Drop deprecations#2109
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: eb4a21e The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
commented
Nov 10, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-shared
branch
from
November 10, 2023 09:09
fe363d9 to
e6c457f
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 10, 2023 09:12
769e1c3 to
89d9c98
Compare
panteliselef
suggested changes
Nov 10, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-shared
branch
from
November 10, 2023 10:40
e6c457f to
cb0f046
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 10, 2023 10:47
89d9c98 to
48c87b1
Compare
panteliselef
approved these changes
Nov 10, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
2 times, most recently
from
November 10, 2023 13:54
b05817b to
937338d
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-shared
branch
from
November 13, 2023 15:53
cb0f046 to
2970cba
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 13, 2023 15:54
937338d to
e013129
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-shared
branch
2 times, most recently
from
November 13, 2023 18:32
4cbb4c9 to
55612d2
Compare
nikosdouvlis
approved these changes
Nov 15, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-shared
branch
from
November 15, 2023 13:45
55612d2 to
f052495
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 15, 2023 14:27
e013129 to
fd01ed2
Compare
dimkl
enabled auto-merge
November 15, 2023 14:27
dimkl
disabled auto-merge
November 15, 2023 14:27
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 15, 2023 15:05
fd01ed2 to
e0107dd
Compare
dimkl
enabled auto-merge
November 15, 2023 15:05
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 15, 2023 15:14
e0107dd to
c82f3ae
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
4 times, most recently
from
November 15, 2023 23:49
2961583 to
6e7e3ec
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 16, 2023 17:23
6e7e3ec to
acafd5b
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 16, 2023 17:27
acafd5b to
418ddc0
Compare
dimkl
commented
Nov 16, 2023
| isSatellite: props.isSatellite || isTruthy(process.env.NEXT_PUBLIC_CLERK_IS_SATELLITE), | ||
| proxyUrl: props.proxyUrl || (process.env.NEXT_PUBLIC_CLERK_PROXY_URL as any), // added as any to cater issue with type resolution | ||
| domain: props.domain || (process.env.NEXT_PUBLIC_CLERK_DOMAIN as any), // added as any to cater issue with type resolution | ||
| isSatellite: props.isSatellite || (isTruthy(process.env.NEXT_PUBLIC_CLERK_IS_SATELLITE) as any), // added as any to cater issue with type resolution |
Contributor
Author
There was a problem hiding this comment.
@panteliselef i had to do this in order for the MultidomainAndOrProxy types to pass. let's discuss it tomorrow and see if we can simplify the type or fix the current issues.
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 16, 2023 17:36
418ddc0 to
d5e3377
Compare
Contributor
Author
|
Moved localization related PRs to #2151 |
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 16, 2023 21:55
d5e3377 to
cc78b25
Compare
…Object` `AuthObject` is a kind of superset of `ServerSideAuth`. The only difference is that instead of `auth.claims` in `AuthObject` you need to use `auth.sessionClaims`
…oviderOptionsWrapper
dimkl
force-pushed
the
sdk-782-drop-deprecations-types
branch
from
November 17, 2023 15:22
cc78b25 to
eb4a21e
Compare
dimkl
added this pull request to the merge queue
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop deprecations. Migration steps:
orgsjwt claim from session tokenauthparam ofwithServerAuth()callback toAuthObjectfromServerSideAuthingatsby-clerk-pluginauth.sessionClaimsinstead ofauth.claimsAuthObjectproperties fromauthpublishableKeyinstead offrontendApiClerkProviderOptionsWrappertype instead ofIsomorphicClerkOptionsChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore