feat(clerk-js,types): Update OrganizationPreview appearance descriptors for OrganizationSwitcher #2158
Merged
octoper merged 4 commits intoNov 22, 2023
Conversation
🦋 Changeset detectedLatest commit: dfa0e52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances
branch
from
November 20, 2023 09:42
698b4e1 to
9226af2
Compare
Contributor
Author
|
!preview |
octoper
force-pushed
the
vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances
branch
from
November 20, 2023 10:36
9226af2 to
6984731
Compare
octoper
marked this pull request as ready for review
November 20, 2023 10:37
octoper
force-pushed
the
vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances
branch
from
November 21, 2023 19:19
6984731 to
cfb3015
Compare
Contributor
Author
|
@brkalow Added! |
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
@octoper can we double the descriptor i commented about ?
panteliselef
approved these changes
Nov 22, 2023
Contributor
|
This PR should resolve #1518 |
octoper
force-pushed
the
vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances
branch
from
November 22, 2023 14:02
f6081cf to
dfa0e52
Compare
octoper
added this pull request to the merge queue
Nov 22, 2023
octoper
deleted the
vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances
branch
November 22, 2023 14:21
desiprisg
pushed a commit
that referenced
this pull request
Nov 23, 2023
…rs for OrganizationSwitcher (#2158) * feat(clerk-js,types): Add id's to the organizationPreview descriptor to allow better customization * feat(clerk-js): Apply changes to ui.retheme * chore(repo): Added Changeset * fix(clerk-js): Use the correct element id for the invitation preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some breaking changes and some additions to the
organzationPreviewdescriptorBreaking Changes
organizationSwitcherid has been renamed toorganizationSwitcherTriggerand the generated element class will be.cl-organizationPreview__organizationSwitcherTriggerAdditions
organizationSwitcherListedOrganizationfor styling listed organization in the<OrganizationSwitcher/>and the generated class will be.cl-organizationPreview__organizationSwitcherListedOrganizationorganizationSwitcherActiveOrganizationfor styling the active organization in the<OrganizationSwitcher/>and the generated class will be.cl-organizationPreview__organizationSwitcherActiveOrganizationnChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore