Skip to content

chore(backend): Limit exposed token verification related errors #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmilewski merged 1 commit into from
Dec 7, 2023
Merged

chore(backend): Limit exposed token verification related errors #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/smooth-baboons-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@clerk/clerk-sdk-node': major
'@clerk/backend': major
'@clerk/nextjs': major
'@clerk/remix': major
---

Limit TokenVerificationError exports to TokenVerificationError and TokenVerificationErrorReason
2 changes: 0 additions & 2 deletions packages/backend/src/exports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ export default (QUnit: QUnit) => {
'SignInToken',
'Token',
'TokenVerificationError',
'TokenVerificationErrorAction',
'TokenVerificationErrorCode',
'TokenVerificationErrorReason',
'User',
'Verification',
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/tokens/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export * from './authObjects';
export { AuthStatus } from './authStatus';
export type { RequestState } from './authStatus';
export * from './errors';
export { TokenVerificationError, TokenVerificationErrorReason } from './errors';

@nikosdouvlis nikosdouvlis Nov 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski As the discussion about the error-related exports for v5 is still ongoing, I think we need to do the following:

  • export the requested error from release/v4
  • remove export * from './errors' from here
  • revisit this then we make a decision

export * from './factory';
export { loadInterstitialFromLocal } from './interstitial';
export { debugRequestState } from './request';
Expand Down
2 changes: 0 additions & 2 deletions packages/nextjs/src/server/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ exports[`/server public exports should not include a breaking change 1`] = `
"SignInToken",
"Token",
"TokenVerificationError",
"TokenVerificationErrorAction",
"TokenVerificationErrorCode",
"TokenVerificationErrorReason",
"User",
"Verification",
Expand Down
2 changes: 0 additions & 2 deletions packages/sdk-node/src/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ exports[`module exports should not change unless explicitly set 1`] = `
"SignInToken",
"Token",
"TokenVerificationError",
"TokenVerificationErrorAction",
"TokenVerificationErrorCode",
"TokenVerificationErrorReason",
"User",
"Verification",
Expand Down