Skip to content

fix(backend,clerk-sdk-node): Resolve reported signature issues #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimkl merged 3 commits into from
Dec 7, 2023
Merged

fix(backend,clerk-sdk-node): Resolve reported signature issues #2284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feaa241
fix(backend): Add `createdAt` param in User#createUser request
dimkl Dec 7, 2023
ab0a97b
fix(clerk-sdk-node): Fix `verifyToken()` signature to support a signl…
dimkl Dec 7, 2023
548b994
chore(repo): Add changeset
dimkl Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/little-dolphins-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-sdk-node': minor
'@clerk/backend': minor
---

Add missing `createdAt` param in `User#createUser()` of `@clerk/backend`.
Fix `clerkClient.verifyToken()` signature to support a single `token: string` parameter.
1 change: 1 addition & 0 deletions packages/backend/src/api/endpoints/UserApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ type CreateUserParams = {
skipPasswordRequirement?: boolean;
totpSecret?: string;
backupCodes?: string[];
createdAt?: Date;
} & UserMetadataParams &
(UserPasswordHashingParams | object);

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk-node/src/clerkClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { loadApiEnv, loadClientEnv } from './utils';
type ExtendedClerk = ReturnType<typeof _Clerk> & {
expressWithAuth: ReturnType<typeof createClerkExpressWithAuth>;
expressRequireAuth: ReturnType<typeof createClerkExpressRequireAuth>;
verifyToken: typeof _verifyToken;
verifyToken: (token: string, verifyOpts?: Parameters<typeof _verifyToken>[1]) => ReturnType<typeof _verifyToken>;

@dimkl dimkl Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will revisit this type as part of the changes in the v5 Project. This is a temporary fix to match the actual type.

};

/**
Expand Down