Skip to content

fix(clerk-react): Fix build process not catching type errors [SDK-1065] #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmilewski wants to merge 4 commits into from
Closed

fix(clerk-react): Fix build process not catching type errors [SDK-1065] #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e610e2
fix(clerk-react): Fix build process not catching type errors
tmilewski Dec 11, 2023
13b4881
fix(localizations,clerk-react,clerk-sdk-node,shared,types): Re-add ts…
tmilewski Dec 12, 2023
d14202e
chore(*): Update changeset
tmilewski Dec 12, 2023
0cdc277
fix(types): Correct existing typing issues
tmilewski Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/many-meals-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@clerk/clerk-react': patch
'@clerk/clerk-sdk-node': patch
'@clerk/localizations': patch
'@clerk/shared': patch
'@clerk/types': patch
---

Re-implement `tsc` type-checking within the build process
1 change: 1 addition & 0 deletions packages/localizations/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,6 @@ export default defineConfig(_overrideOptions => {
sourcemap: true,
dts: true,
splitting: false,
onSuccess: 'tsc',

@LekoArts LekoArts Dec 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set dts: false then? Then we'd do double the work

};
});
1 change: 1 addition & 0 deletions packages/react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"baseUrl": ".",
"declaration": true,
"declarationMap": false,
"emitDeclarationOnly": true,
"esModuleInterop": true,
"importHelpers": true,
"isolatedModules": true,
Expand Down
4 changes: 1 addition & 3 deletions packages/react/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { defineConfig } from 'tsup';

// @ts-expect-error for `import module with '.json' extension`
import { version as clerkJsVersion } from '../clerk-js/package.json';
// @ts-expect-error for `import module with '.json' extension`
import { name, version } from './package.json';

export default defineConfig(overrideOptions => {
Expand All @@ -13,7 +11,7 @@ export default defineConfig(overrideOptions => {
entry: {
index: 'src/index.ts',
},
onSuccess: shouldPublish ? 'npm run publish:local' : undefined,
onSuccess: ['tsc', shouldPublish ? 'npm run publish:local' : undefined].filter(Boolean).join(' && '),
format: ['cjs', 'esm'],
bundle: true,
clean: true,
Expand Down
1 change: 1 addition & 0 deletions packages/sdk-node/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default defineConfig(overrideOptions => {
minify: false,
sourcemap: true,
dts: true,
onSuccess: 'tsc',
define: {
PACKAGE_NAME: `"${name}"`,
PACKAGE_VERSION: `"${version}"`,
Expand Down
1 change: 1 addition & 0 deletions packages/shared/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default defineConfig(overrideOptions => {
minify: false,
sourcemap: true,
dts: true,
onSuccess: 'tsc',
external: ['react', 'react-dom'],
esbuildPlugins: [WebWorkerMinifyPlugin as any],
define: {
Expand Down
4 changes: 4 additions & 0 deletions packages/types/src/localization.retheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ type _LocalizationResource = {
start: {
headerTitle__account: LocalizationValue;
headerTitle__security: LocalizationValue;
headerSubtitle__account: LocalizationValue;
headerSubtitle__security: LocalizationValue;
profileSection: {
title: LocalizationValue;
};
Expand Down Expand Up @@ -554,6 +556,8 @@ type _LocalizationResource = {
start: {
headerTitle__members: LocalizationValue;
headerTitle__settings: LocalizationValue;
headerSubtitle__members: LocalizationValue;
headerSubtitle__settings: LocalizationValue;
};
profilePage: {
title: LocalizationValue;
Expand Down
8 changes: 8 additions & 0 deletions packages/types/src/localization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ type _LocalizationResource = {
formButtonPrimary__continue: LocalizationValue;
formButtonPrimary__finish: LocalizationValue;
formButtonReset: LocalizationValue;
navbar: {
title: LocalizationValue;
description: LocalizationValue;
};
start: {
headerTitle__account: LocalizationValue;
headerTitle__security: LocalizationValue;
Expand Down Expand Up @@ -545,6 +549,10 @@ type _LocalizationResource = {
badge__automaticInvitation: LocalizationValue;
badge__automaticSuggestion: LocalizationValue;
badge__manualInvitation: LocalizationValue;
navbar: {
title: LocalizationValue;
description: LocalizationValue;
};
start: {
headerTitle__members: LocalizationValue;
headerTitle__settings: LocalizationValue;
Expand Down
1 change: 1 addition & 0 deletions packages/types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"moduleResolution": "node",
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand Down
1 change: 1 addition & 0 deletions packages/types/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export default defineConfig(() => {
entry: {
index: uiRetheme ? 'src/index.retheme.ts' : 'src/index.ts',
},
onSuccess: 'tsc',
minify: false,
clean: true,
sourcemap: true,
Expand Down