feat(nextjs): Accept redirectUrl as option for auth().protect()#2329
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ccbdff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@brkalow @nikosdouvlis Do you find this too annoying ? Types for params are already too complex. auth().protect(undefined, { redirectUrl:'/any-page' }) |
chanioxaris
approved these changes
Dec 12, 2023
Contributor
Author
|
Avoid merging before the question above is answered |
Member
|
@panteliselef Is the alternative to adjust the types such that this is possible? auth().protect({ redirectUrl: '/' })I think I prefer this. ☝️ It feels like we're trying to dissuade people from using the option if they need to do this for the authn scenario: auth().protect(undefined, { redirectUrl: '/' }) |
dimkl
approved these changes
Dec 13, 2023
LekoArts
reviewed
Dec 13, 2023
24 tasks
…arameter"" This reverts commit 2b0f942.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows developers to call
auth().protect()and pass to it aredirectUrlwhich can be used as the fallback instead of the standard 404 error that we currently throw.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore