chore(*): Improve @clerk/backend DX [Part 6 - token and jwt utils return values]#2377
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 23127d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SokratisVidros
suggested changes
Dec 15, 2023
…Token` return value
156f4d4 to
9e9e0d1
Compare
9e9e0d1 to
88532d1
Compare
… backend `JwtReturnType`
88532d1 to
23127d5
Compare
SokratisVidros
approved these changes
Dec 15, 2023
octoper
pushed a commit
that referenced
this pull request
Dec 16, 2023
…urn values] (#2377) * chore(backend,types): Introduce ReturnWithError and use it as `verifyToken` return value * chore(backend,types): Make /jwt subpath utilies to return `ReturnWithError` type * chore(backend,types): Rename and move `ReturnWithError` move types to backend `JwtReturnType`
dimkl
added a commit
to clerk/clerk-docs
that referenced
this pull request
Jan 13, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change return values of
signJwt,hasValidSignature,decodeJwt,verifyJwt,verifyTokento return
{ data, error }. Example of keeping the same behaviour using those utilies:Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore