Skip to content

feat(remix): Support handshake flow for remix#2380

Merged
nikosdouvlis merged 5 commits into
mainfrom
brk.feat/remix-handshake
Dec 15, 2023
Merged

feat(remix): Support handshake flow for remix#2380
nikosdouvlis merged 5 commits into
mainfrom
brk.feat/remix-handshake

Conversation

@brkalow

@brkalow brkalow commented Dec 15, 2023

Copy link
Copy Markdown
Member

Description

Support the handshake flow for Remix.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot

changeset-bot Bot commented Dec 15, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e4aa1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/remix Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis nikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much all that's needed :)

We might need to do something in ssr/getAuth as well. I did replace the error thrown in a previous PR with a redirect('') but could you please check whether we need something more or not? (and remove the todo ofc)

We want to halt execution in the nested loaders as all loaders (nested and root) run in parallel - we halt execution by throwing a redirect or an error. Remix evaluates errors first, so we should test that calling redirect with '' does indeed throw a redirect and not an error because of the invalid URL

Comment thread .changeset/itchy-chairs-call.md Outdated
'@clerk/remix': minor
---

Update the Remix rootAuthLoader to handle handshake auth status, this replaces the previous interstitial flow.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include a short migration guide as the ClerkErrorBoundary export is no longer needed :)

@nikosdouvlis nikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@brkalow brkalow enabled auto-merge December 15, 2023 22:56
@nikosdouvlis nikosdouvlis merged commit fa68746 into main Dec 15, 2023
@nikosdouvlis nikosdouvlis deleted the brk.feat/remix-handshake branch December 15, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants