fix(backend): Replace OrganizationMembershipRole with custom types for authorization#2408
Merged
Conversation
…for authorization
🦋 Changeset detectedLatest commit: c0024fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24 tasks
tmilewski
approved these changes
Dec 19, 2023
RodneyU215
reviewed
Dec 20, 2023
| export type OrganizationInvitationStatus = 'pending' | 'accepted' | 'revoked'; | ||
|
|
||
| export type OrganizationMembershipRole = 'basic_member' | 'guest_member' | 'admin'; | ||
| export type OrganizationMembershipRole = OrganizationCustomRoleKey; |
There was a problem hiding this comment.
Please forgive my ignorance but would we not want to include the default roles 'org:member' | 'org:admin' here as well? We had a customer reach out to support regarding this TS error.
Contributor
Author
There was a problem hiding this comment.
As discussed we will not add the default roles in types for the time being, customers will be unblocked with the fix from this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will be backported by #2405
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore