chore(astro): Remove deprecated as prop from button components#5140
chore(astro): Remove deprecated as prop from button components#5140wobsoriano wants to merge 3 commits into
as prop from button components#5140Conversation
🦋 Changeset detectedLatest commit: 0e41a34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
as prop in unstyled button components
as prop in unstyled button componentsas prop from button components
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| "@clerk/astro": minor | |||
There was a problem hiding this comment.
🤔 Isn't this a breaking change?
There was a problem hiding this comment.
Good question! Hmmm originally when the as prop was added, we immediately did a follow up and introduced the asChild prop and documented that instead.
If we're going major on this one, I think we can skip this PR for now as it will be a waste of a major version bump. We can include this change in our next major release when we introduce more features / breaking change 👍🏼
There was a problem hiding this comment.
i think this is a breaking change, we should schedule for the next major instead.
There was a problem hiding this comment.
Yeah, I will close this PR for now and revisit on our next major!
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| "@clerk/astro": minor | |||
There was a problem hiding this comment.
i think this is a breaking change, we should schedule for the next major instead.
| <Fragment set:html={htmlElement} /> | ||
| ) : ( | ||
| <Tag {...props} data-clerk-unstyled-id={safeId}> | ||
| <button {...props} data-clerk-unstyled-id={safeId}> |
There was a problem hiding this comment.
with asChild aren't we loosing data-clerk-unstyled-id ? is that ok ?
Description
It's been 5 months since we began deprecating the
asprop in favor ofasChildfor customizing our unstyled components (<SignInButton />,<SignUpButton />,<SignOutButton />). As documented in our component guides, theasChildprop is the recommended approach for passing custom buttons. This PR completes the deprecation by removing theasprop entirely.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change