Skip to content

fix(e2e): Port reverifiation test fix to Core 2 #9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wobsoriano merged 2 commits into from
Aug 4, 2026
Merged

fix(e2e): Port reverifiation test fix to Core 2 #9327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3915e
ci(repo): retrigger release
wobsoriano Aug 4, 2026
29ae2be
fix(e2e): Stop relying on startVerification to reset fva in reverific…
wobsoriano Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/retrigger-core-2-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
43 changes: 31 additions & 12 deletions integration/tests/reverification.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,22 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withReverification] })(
await u.page.getByRole('button', { name: /LogUserId/i }).click();
await expect(u.page.getByText(/\{\s*"userId"\s*:\s*"user_[^"]+"\s*\}/i)).toBeVisible();

// Hack to reset fva
// startVerification no longer resets fva server-side, so age the signed-in factor past afterMinutes
await u.po.expect.toBeSignedIn();
await page.evaluate(async () => {
return window.Clerk.session.startVerification({
level: 'first_factor',
});
});
await expect
.poll(
() =>
page.evaluate(async () => {
const token = await window.Clerk.session?.getToken({ skipCache: true });
if (!token) {
return -1;
}
const payload = token.split('.')[1].replace(/-/g, '+').replace(/_/g, '/');
return JSON.parse(atob(payload)).fva?.[0] ?? -1;
}),
{ intervals: [5_000], timeout: 120_000 },
)
.toBeGreaterThanOrEqual(1);
await u.page.goToRelative(`/requires-re-verification`);
await u.page.getByRole('button', { name: /LogUserId/i }).click();
await expect(
Expand All @@ -248,6 +257,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withReverification] })(
});

test(`reverification recovery from ${capitalize(type)}`, async ({ page, context }) => {
test.setTimeout(270_000);
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
Expand All @@ -263,13 +273,22 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withReverification] })(
await u.page.getByRole('button', { name: /LogUserId/i }).click();
await expect(u.page.getByText(/\{\s*"userId"\s*:\s*"user_[^"]+"\s*\}/i)).toBeVisible();

// Hack to reset fva
// startVerification no longer resets fva server-side, so age the signed-in factor past afterMinutes
await u.po.expect.toBeSignedIn();
await page.evaluate(async () => {
return window.Clerk.session.startVerification({
level: 'first_factor',
});
});
await expect
.poll(
() =>
page.evaluate(async () => {
const token = await window.Clerk.session?.getToken({ skipCache: true });
if (!token) {
return -1;
}
const payload = token.split('.')[1].replace(/-/g, '+').replace(/_/g, '/');
return JSON.parse(atob(payload)).fva?.[0] ?? -1;
}),
{ intervals: [5_000], timeout: 120_000 },
)
.toBeGreaterThanOrEqual(1);

await u.page.goToRelative(`/action-with-use-reverification`);
await u.po.expect.toBeSignedIn();
Expand Down
Loading