Skip to content

C# Clean Up - #5500

Merged
bfops merged 5 commits into
masterfrom
lisandro/net10-cleanup
Jul 27, 2026
Merged

bfops merged 5 commits into
masterfrom
lisandro/net10-cleanup

Conversation

@lisandroct

@lisandroct lisandroct commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

Just a syntax clean up. It removes a ton of warnings when building the C# project now that we're on .NET 10 (apparently the analyzer is more sensitive or picky).

API and ABI breaking changes

None.

Expected complexity level and risk

  1. Extremely trivial. All syntax changes.

Testing

  • crates/bindings-csharp builds and tests pass

@lisandroct
lisandroct marked this pull request as draft July 8, 2026 18:56
Comment thread sdks/csharp/src/SpacetimeDBClient.cs Outdated
@lisandroct
lisandroct force-pushed the lisandro/net10-cleanup branch from 49855e9 to 7ae73f1 Compare July 17, 2026 13:54
@lisandroct
lisandroct force-pushed the lisandro/net10-cleanup branch from 682d87c to 1cf8147 Compare July 17, 2026 19:29
@lisandroct
lisandroct marked this pull request as ready for review July 17, 2026 19:38
@lisandroct lisandroct self-assigned this Jul 17, 2026

@JasonAtClockwork JasonAtClockwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisandroct
lisandroct enabled auto-merge July 20, 2026 19:59

@bfops bfops left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my code-owned files LGTM

@lisandroct
lisandroct added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 27, 2026
@lisandroct
lisandroct added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 27, 2026
@bfops
bfops added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026
@bfops
bfops added this pull request to the merge queue Jul 27, 2026
Merged via the queue into master with commit f9f1e19 Jul 27, 2026
54 of 55 checks passed
pull Bot pushed a commit to soitun/SpacetimeDB that referenced this pull request Aug 25, 2026
# Description of Changes

Fixes clockworklabs#5759.

Restores `using System.Collections;` in
`sdks/csharp/src/SpacetimeDBClient.cs` so the Unity WebGL-only
`IEnumerator ParseMessages()` coroutine resolves to the non-generic
`System.Collections.IEnumerator` type.

# API and ABI breaking changes

None.

# Expected complexity level and risk

1. This restores an import that existed before clockworklabs#5500 and only affects
type resolution for the existing WebGL coroutine declaration.

# Testing

- [x] `git diff --check`
- [x] Verified `using System.Collections;` is present alongside
`internal IEnumerator ParseMessages()`
- [ ] Not run locally: `dotnet` is not installed in this runtime
- [ ] Not run locally: Unity WebGL Player build

---------

Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants