Skip to content

Allow monomorphization for reducers and more #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lisandroct merged 8 commits into from
Sep 3, 2026
Merged

Allow monomorphization for reducers and more #5610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76d71e8
Add static generic caches for reducers and more
lisandroct Jul 17, 2026
610c8e0
Remove unnecessary ToArray()
lisandroct Aug 13, 2026
d522f41
Dispose the http request body stream in the generic path
lisandroct Aug 26, 2026
2e78e4c
Generate direct C# module dispatch for all build modes (AOT and non AOT)
lisandroct Aug 26, 2026
cd4c367
Fix .NET 8
lisandroct Aug 27, 2026
9101383
Fix lint
lisandroct Aug 27, 2026
539a73a
Merge branch 'master' into lisandro/allow-monomorphization-for-reduce…
JasonAtClockwork Aug 28, 2026
a79b085
Merge branch 'master' into lisandro/allow-monomorphization-for-reduce…
lisandroct Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,057 changes: 977 additions & 80 deletions crates/bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#FFI.verified.cs
View file
Open in desktop

Large diffs are not rendered by default.

261 changes: 208 additions & 53 deletions crates/bindings-csharp/Codegen.Tests/fixtures/explicitnames/snapshots/Module#FFI.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar
)
);

public byte[] Invoke(
public static byte[] Invoke(
System.IO.BinaryReader reader,
global::SpacetimeDB.Internal.IViewContext ctx
)
Expand Down Expand Up @@ -511,7 +511,16 @@ public sealed partial class LocalReadOnly

static class ModuleRegistration
{
class DemoReducer : SpacetimeDB.Internal.IReducer
// Module host calls are single-threaded in Wasm today, so the generated
// entrypoints reuse buffers across calls to avoid per-invocation allocation.
private static byte[] reducerArgsBuffer = new byte[0x10_000];
private static byte[] procedureArgsBuffer = new byte[0x10_000];
private static byte[] httpRequestBuffer = new byte[0x10_000];
private static byte[] httpRequestBodyBuffer = new byte[0x10_000];
private static byte[] viewArgsBuffer = new byte[0x10_000];
private static byte[] anonymousViewArgsBuffer = new byte[0x10_000];

sealed class DemoReducer : SpacetimeDB.Internal.IReducer
{
private static readonly SpacetimeDB.BSATN.I32 valueRW = new();

Expand All @@ -528,13 +537,13 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar

public SpacetimeDB.Internal.Lifecycle? Lifecycle => null;

public void Invoke(BinaryReader reader, SpacetimeDB.Internal.IReducerContext ctx)
public static void Invoke(BinaryReader reader, SpacetimeDB.Internal.IReducerContext ctx)
{
Reducers.DemoReducer((SpacetimeDB.ReducerContext)ctx, valueRW.Read(reader));
}
}

class DemoProcedure : SpacetimeDB.Internal.IProcedure
sealed class DemoProcedure : SpacetimeDB.Internal.IProcedure
{
public SpacetimeDB.Internal.RawProcedureDefV10 MakeProcedureDef(
SpacetimeDB.BSATN.ITypeRegistrar registrar
Expand All @@ -546,7 +555,7 @@ SpacetimeDB.BSATN.ITypeRegistrar registrar
Visibility: SpacetimeDB.Internal.FunctionVisibility.ClientCallable
);

public byte[] Invoke(BinaryReader reader, SpacetimeDB.Internal.IProcedureContext ctx)
public static byte[] Invoke(BinaryReader reader, SpacetimeDB.Internal.IProcedureContext ctx)
{
Reducers.DemoProcedure((SpacetimeDB.ProcedureContext)ctx);
return System.Array.Empty<byte>();
Expand All @@ -565,10 +574,7 @@ public static List<T> ToListOrEmpty<T>(T? value)
[UnmanagedCallersOnly(EntryPoint = "__preinit__10_init_csharp")]
#else
// Prevent trimming of FFI exports that are invoked from C and not visible to C# trimmer.
[DynamicDependency(
DynamicallyAccessedMemberTypes.PublicMethods,
typeof(SpacetimeDB.Internal.Module)
)]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicMethods, typeof(ModuleRegistration))]
#endif
public static void Main()
{
Expand Down Expand Up @@ -627,13 +633,125 @@ public static void Main()
>();
}

// Exports only work from the main assembly, so we need to generate forwarding methods.
// Export entrypoints live in generated module code so all build modes can
// dispatch directly to concrete generated functions.
#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__describe_module__")]
#endif
public static void __describe_module__(SpacetimeDB.Internal.BytesSink d) =>
SpacetimeDB.Internal.Module.__describe_module__(d);

private static SpacetimeDB.Internal.Errno __call_reducer_0(
ulong sender_0,
ulong sender_1,
ulong sender_2,
ulong sender_3,
ulong conn_id_0,
ulong conn_id_1,
SpacetimeDB.Timestamp timestamp,
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink error
)
{
try
{
var ctx = SpacetimeDB.Internal.Module.CreateReducerContext(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp
);
using var stream = SpacetimeDB.Internal.Module.ConsumeBytes(
args,
ref reducerArgsBuffer
);
using var reader = new System.IO.BinaryReader(stream);
DemoReducer.Invoke(reader, ctx);
SpacetimeDB.Internal.Module.EnsureNoUnreadBytes(stream, "reducer arguments");
return SpacetimeDB.Internal.Errno.OK;
}
catch (System.Exception e)
{
return SpacetimeDB.Internal.Module.WriteReducerError(error, e);
}
}

private static SpacetimeDB.Internal.Errno __call_procedure_0(
ulong sender_0,
ulong sender_1,
ulong sender_2,
ulong sender_3,
ulong conn_id_0,
ulong conn_id_1,
SpacetimeDB.Timestamp timestamp,
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink result_sink
)
{
try
{
var ctx = SpacetimeDB.Internal.Module.CreateProcedureContext(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp
);
using var stream = SpacetimeDB.Internal.Module.ConsumeBytes(
args,
ref procedureArgsBuffer
);
using var reader = new System.IO.BinaryReader(stream);
var bytes = DemoProcedure.Invoke(reader, ctx);
SpacetimeDB.Internal.Module.EnsureNoUnreadBytes(stream, "procedure arguments");
SpacetimeDB.Internal.Module.WriteBytes(result_sink, bytes);
return SpacetimeDB.Internal.Errno.OK;
}
catch (System.Exception e)
{
SpacetimeDB.Log.Error($"Error while invoking procedure: {e}");
throw;
}
}

private static SpacetimeDB.Internal.Errno __call_view_0(
ulong sender_0,
ulong sender_1,
ulong sender_2,
ulong sender_3,
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink sink
)
{
try
{
var ctx = SpacetimeDB.Internal.Module.CreateViewContext(
sender_0,
sender_1,
sender_2,
sender_3
);
using var stream = SpacetimeDB.Internal.Module.ConsumeBytes(args, ref viewArgsBuffer);
using var reader = new System.IO.BinaryReader(stream);
var bytes = demo_viewViewDispatcher.Invoke(reader, ctx);
SpacetimeDB.Internal.Module.WriteBytes(sink, bytes);
return (SpacetimeDB.Internal.Errno)2;
}
catch (System.Exception e)
{
SpacetimeDB.Log.Error($"Error while invoking view: {e}");
return SpacetimeDB.Internal.Errno.HOST_CALL_FAILURE;
}
}

#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__call_reducer__")]
#endif
public static SpacetimeDB.Internal.Errno __call_reducer__(
int id,
ulong sender_0,
Expand All @@ -646,20 +764,30 @@ public static SpacetimeDB.Internal.Errno __call_reducer__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink error
) =>
SpacetimeDB.Internal.Module.__call_reducer__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
error
);
id switch
{
0
=> __call_reducer_0(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
error
),
_
=> SpacetimeDB.Internal.Module.WriteReducerError(
error,
new System.ArgumentOutOfRangeException(nameof(id), id, "Unknown reducer id")
)
};

#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__call_procedure__")]
#endif
public static SpacetimeDB.Internal.Errno __call_procedure__(
int id,
ulong sender_0,
Expand All @@ -672,20 +800,31 @@ public static SpacetimeDB.Internal.Errno __call_procedure__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink result_sink
) =>
SpacetimeDB.Internal.Module.__call_procedure__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
result_sink
);
id switch
{
0
=> __call_procedure_0(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
result_sink
),
_
=> throw new System.ArgumentOutOfRangeException(
nameof(id),
id,
"Unknown procedure id"
)
};

#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__call_http_handler__")]
#endif
public static SpacetimeDB.Internal.Errno __call_http_handler__(
int id,
SpacetimeDB.Timestamp timestamp,
Expand All @@ -694,16 +833,19 @@ public static SpacetimeDB.Internal.Errno __call_http_handler__(
SpacetimeDB.Internal.BytesSink response_sink,
SpacetimeDB.Internal.BytesSink response_body_sink
) =>
SpacetimeDB.Internal.Module.__call_http_handler__(
id,
timestamp,
request,
request_body,
response_sink,
response_body_sink
);
id switch
{
_
=> throw new System.ArgumentOutOfRangeException(
nameof(id),
id,
"Unknown HTTP handler id"
)
};

#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__call_view__")]
#endif
public static SpacetimeDB.Internal.Errno __call_view__(
int id,
ulong sender_0,
Expand All @@ -713,23 +855,36 @@ public static SpacetimeDB.Internal.Errno __call_view__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink sink
) =>
SpacetimeDB.Internal.Module.__call_view__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
args,
sink
);
id switch
{
0 => __call_view_0(sender_0, sender_1, sender_2, sender_3, args, sink),
_ => UnknownViewId(id)
};

#if EXPERIMENTAL_WASM_AOT || NET10_0_OR_GREATER
[UnmanagedCallersOnly(EntryPoint = "__call_view_anon__")]
#endif
public static SpacetimeDB.Internal.Errno __call_view_anon__(
int id,
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink sink
) => SpacetimeDB.Internal.Module.__call_view_anon__(id, args, sink);
#endif
) =>
id switch
{
_ => UnknownAnonymousViewId(id)
};

private static SpacetimeDB.Internal.Errno UnknownViewId(int id)
{
SpacetimeDB.Log.Error($"Unknown view id: {id}");
return SpacetimeDB.Internal.Errno.HOST_CALL_FAILURE;
}

private static SpacetimeDB.Internal.Errno UnknownAnonymousViewId(int id)
{
SpacetimeDB.Log.Error($"Unknown anonymous view id: {id}");
return SpacetimeDB.Internal.Errno.HOST_CALL_FAILURE;
}
}

#pragma warning restore STDB_UNSTABLE
Expand Down
Loading
Loading