Make egress-tracking middleware apply to MCP route - #5775
Merged
Conversation
clockwork-tien
marked this pull request as ready for review
August 21, 2026 14:13
gefjon
reviewed
Aug 21, 2026
aasoni
approved these changes
Aug 24, 2026
1 task
clockwork-tien
force-pushed
the
tien/feat/egress-mcp-route
branch
from
August 24, 2026 15:51
98f8bde to
0d24b96
Compare
clockwork-tien
enabled auto-merge
August 24, 2026 16:28
1 task
pull Bot
pushed a commit
to age-rs/SpacetimeDB
that referenced
this pull request
Aug 31, 2026
# Description of Changes Related PR clockworklabs#5775 Closes clockworklabs#5789 - Add egress tracking directly in mcp_root - Implement counting egress bytes for calls that go through mcp_root (host-wide MCP route), since egress middleware resolves database from the URL path, while mcp_root names its database in a tool argument inside the request body which path based middleware can not see. <!-- Please describe your change, mention any related tickets, and so on here. --> # API and ABI breaking changes None. <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> # Expected complexity level and risk 2 <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] I tested the implementation, tests, lint and format checks passed Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
/v1/database/:name_or_identity/mcpout of the bypass list intocounted_db_routerAPI and ABI breaking changes
None.
Expected complexity level and risk
2
Testing