feat(runners): add runs_on input to infracost, smurf-tf-checks and tf-drift - #453
Closed
clouddrove-ci wants to merge 1 commit into
Closed
clouddrove-ci wants to merge 1 commit into
clouddrove-ci wants to merge 1 commit into
Conversation
…-drift Same input and default as smurf-helm-deploy and smurf-docker: runs_on defaults to ubuntu-latest, so existing callers are unchanged. Callers on self-hosted runners (for example an org k3s ARC scale set) can pass their label; today these three workflows cannot run anywhere GitHub-hosted runners are unavailable.
Member
Author
|
Closing: not pursuing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
runs_oninput toinfracost.yml,smurf-tf-checks.ymlandtf-drift.yml, with the same name, type and default (ubuntu-latest) thatsmurf-helm-deploy.ymlandsmurf-docker.ymlalready use. Everyruns-on: ubuntu-latestin those three workflows becomesruns-on: ${{ inputs.runs_on }}(1, 3 and 1 jobs).Existing callers are unchanged. Callers that must run on self-hosted runners (for example clouddrove/cd-baseline on the org k3s ARC scale set
arc-runners, where GitHub-hosted runners are blocked) can pass their label. cd-baseline currently has these three callers paused withif: falsefor exactly this reason.Docs:
runs_onadded to the usage examples indocs/infracost.mdanddocs/smurf-tf-checks.md.Type of Change
Testing
Release
Needs a patch tag (e.g. v2.1.8) so callers can pin it.