Skip to content

Update CI to build for all matrix targets - #188

Merged
nox merged 15 commits into
cloudflare:masterfrom
signalapp:ci_matrix_targets
Dec 14, 2023
Merged

Update CI to build for all matrix targets#188
nox merged 15 commits into
cloudflare:masterfrom
signalapp:ci_matrix_targets

Conversation

@eager-signal

Copy link
Copy Markdown
Contributor

We noticed that the CI matrix wasn’t always building for the Rust target it intended, leading to surprise breakage (e.g. #187) when doing release builds. This addresses that in a few ways:

  1. add --target to cargo test
  2. check_only flag
    • skip running tests for non-native architectures and targets; instead do cargo build … --tests to confirm cross-compilation
  3. various customization options
    • specific packages required to cross-compile for the target, environment variables, etc.
  4. last resort: drop a target
    • musl doesn’t have a standard C++ setup to use

@nox

nox commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

Thanks for the impressive PR! Can you please rebase on top of master now that #187 is merged? Thanks.

@eager-signal

Copy link
Copy Markdown
Contributor Author

Can you please rebase on top of master now that #187 is merged? Thanks.

@nox yep, done!

@jrose-signal

Copy link
Copy Markdown
Contributor

Fixes #62 :-)

@nox
nox merged commit dd281f6 into cloudflare:master Dec 14, 2023
@eager-signal
eager-signal deleted the ci_matrix_targets branch December 14, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants