Skip to content

Introduce HandshakeError::code - #31

Merged
inikulin merged 1 commit into
cloudflare:masterfrom
nox:unexpected-eof
Apr 16, 2021
Merged

Introduce HandshakeError::code#31
inikulin merged 1 commit into
cloudflare:masterfrom
nox:unexpected-eof

Conversation

@nox

@nox nox commented Apr 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@nox

nox commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Oh, that doesn't work as I expected it to. I wonder if we should special case those specific errors during handshake only then.

@nox
nox force-pushed the unexpected-eof branch from 65937b0 to 0cf0ab7 Compare April 16, 2021 10:45
@nox nox changed the title Generate UnexpectedEof error if BIO layer returned no error Introduce HandshakeError::code Apr 16, 2021
@nox

nox commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

I've repurposed the PR to be about exposing the handshake error's code so that we can inspect it on our own from where we consume the damn handshake error.

@nox
nox force-pushed the unexpected-eof branch from 0cf0ab7 to 4473d08 Compare April 16, 2021 10:48
@inikulin
inikulin merged commit 61e69eb into cloudflare:master Apr 16, 2021
@nox
nox deleted the unexpected-eof branch April 16, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants