Conversation
Lekensteyn
left a comment
There was a problem hiding this comment.
golagnci-lint needs to be updated to at least v2.13.0 for Go 1.27 support (v2.13.3 is the current latest version): https://github.com/golangci/golangci-lint/releases
Can this workaround from #701 also be removed now that the minimum is bumped?
# Pin x/tools to a version compatible with the oldest Go version in the CI matrix.
go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@v0.49.0
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| run: | | ||
| # Pin x/tools to a version compatible with the oldest Go version in the CI matrix. | ||
| go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@v0.49.0 | ||
| go install golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@latest |
There was a problem hiding this comment.
🟡 Unpinned shadow analyzer destabilizes CI
When x/tools raises its Go requirement, @latest breaks the Go 1.26 matrix without repository changes. The previous pin kept the analyzer compatible with the oldest compiler.
Prompt for agents
Pin golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow to a tested x/tools release that supports both Go 1.26 and Go 1.27. Keep that version explicit in .github/workflows/ci-actions.yml so CI behavior and minimum-version compatibility do not change when x/tools publishes a new release.
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.