Skip to content

[miniflare] Enforce curly lint rule - #15408

Open
penalosa wants to merge 1 commit into
mainfrom
penalosa/miniflare-curly
Open

[miniflare] Enforce curly lint rule#15408
penalosa wants to merge 1 commit into
mainfrom
penalosa/miniflare-curly

Conversation

@penalosa

Copy link
Copy Markdown
Contributor

What this PR does

  • Enables the repo-wide curly lint rule for packages/miniflare/**.
  • Adds braces to the existing single-line control flow statements — no behaviour changes.
  • Updates the Miniflare agent guidance to remove curly from the transitional disabled-rule list.

No changeset — this is an internal lint-only refactor with no user-facing impact.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this is a mechanical lint-only refactor; the existing Miniflare test suite passes.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this only changes internal lint enforcement and code style.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2022ad8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15408

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15408

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15408

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15408

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15408

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15408

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15408

miniflare

npm i https://pkg.pr.new/miniflare@15408

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15408

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15408

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15408

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15408

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15408

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15408

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15408

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15408

wrangler

npm i https://pkg.pr.new/wrangler@15408

commit: 2022ad8

@penalosa
penalosa marked this pull request as ready for review August 28, 2026 15:50
@workers-devprod
workers-devprod requested review from a team and jamesopstad and removed request for a team August 28, 2026 15:51
@workers-devprod

workers-devprod commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/workers-kv
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/workers/kv/constants.ts: [@cloudflare/workers-kv]
  • packages/miniflare/src/workers/kv/namespace.worker.ts: [@cloudflare/workers-kv]
  • packages/miniflare/src/workers/kv/sites.worker.ts: [@cloudflare/workers-kv]
  • packages/miniflare/src/workers/kv/validator.worker.ts: [@cloudflare/workers-kv]
  • packages/miniflare/test/plugins/kv/sites.spec.ts: [@cloudflare/workers-kv]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks! 😄 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants