Skip to content

Prototype/card polish - #1282

Merged
AriannaChau merged 2 commits into
v-nextfrom
prototype/card-polish
Jun 7, 2021
Merged

Prototype/card polish#1282
AriannaChau merged 2 commits into
v-nextfrom
prototype/card-polish

Conversation

@AriannaChau

@AriannaChau AriannaChau commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Overview

This PR addresses some feedback Tyler left with the card variations that were made a couple weeks ago.

Screenshots

Light theme

Light on light:
Screen Shot 2021-06-07 at 9 40 29 AM

Dark on light
Screen Shot 2021-06-07 at 9 40 37 AM

Dark theme

Dark on dark
Screen Shot 2021-06-07 at 9 40 45 AM

Light on dark
Screen Shot 2021-06-07 at 9 40 52 AM

Testing

  1. Deploy link

@changeset-bot

changeset-bot Bot commented Jun 7, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a5106a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AriannaChau
AriannaChau marked this pull request as ready for review June 7, 2021 17:00
@AriannaChau
AriannaChau requested a review from tylersticka June 7, 2021 17:00
@AriannaChau
AriannaChau merged commit c54cb32 into v-next Jun 7, 2021
@AriannaChau
AriannaChau deleted the prototype/card-polish branch June 7, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize card variation designs

2 participants