Add c-card--contained modifier - #1287
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b0015e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
c-card--containedmodifier, giving cards distinct boundaries to offset them from their containing element.unthemed-stylesmixin to define styles that should apply only when a theme class is not directly attached to the element.This PR does not include the distinctly separated footer from the rest of the card contents. I realized partway into this task that making this happen would represent 95% of the effort, but that design detail is only present on PWA Stats. Because there's another issue blocked by this and many more directly related to our short-term goals, it felt odd to spend many more hours (if not days) refactoring for this design detail we wouldn't use right away. I plan to create another issue to address that detail at a later date.
Screenshots
Testing
Deploy preview