fix(code-editor): Allow for correct border radius theming - #242
Merged
Conversation
fralongo
requested review from
michaeldowseza
and removed request for
a team
September 5, 2022 07:25
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 555 555
Lines 15708 15708
Branches 4295 4295
=======================================
Hits 14560 14560
Misses 1067 1067
Partials 81 81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fralongo
force-pushed
the
fralongo-code-editor-radius-fix
branch
from
September 5, 2022 13:16
6c1cdfd to
cad3ca1
Compare
michaeldowseza
approved these changes
Sep 5, 2022
fralongo
added a commit
that referenced
this pull request
Sep 7, 2022
…)" This reverts commit d710d07.
fralongo
added a commit
that referenced
this pull request
Sep 7, 2022
…)" This reverts commit d710d07.
katiegeorge
pushed a commit
that referenced
this pull request
Sep 12, 2022
katiegeorge
pushed a commit
that referenced
this pull request
Sep 12, 2022
…)" This reverts commit d710d07.
katiegeorge
pushed a commit
that referenced
this pull request
Nov 1, 2022
katiegeorge
pushed a commit
that referenced
this pull request
Nov 1, 2022
…)" This reverts commit d710d07.
rubencarvalho
pushed a commit
that referenced
this pull request
Jan 16, 2023
rubencarvalho
pushed a commit
that referenced
this pull request
Jan 16, 2023
…)" This reverts commit d710d07.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows to set a custom value for code editor border radius. The fix is needed before making the border radius themeable (#221)
How has this been tested?
[How did you test to verify your changes?] Locally
[Check for unexpected visual regressions, see
CONTRIBUTING.mdfor details.]Documentation changes
[Do the changes include any API documentation changes?]
Related Links
#221
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.maxCSS function is supported in all browsers that Cloudscape supports: https://developer.mozilla.org/en-US/docs/Web/CSS/maxSecurity
checkSafeUrlfunction.Testing
Covered by internal visual regression tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.