Skip to content

fix(code-editor): Allow for correct border radius theming - #242

Merged
fralongo merged 1 commit into
mainfrom
fralongo-code-editor-radius-fix
Sep 5, 2022
Merged

fix(code-editor): Allow for correct border radius theming#242
fralongo merged 1 commit into
mainfrom
fralongo-code-editor-radius-fix

Conversation

@fralongo

@fralongo fralongo commented Sep 5, 2022

Copy link
Copy Markdown
Member

Description

Allows to set a custom value for code editor border radius. The fix is needed before making the border radius themeable (#221)

How has this been tested?

[How did you test to verify your changes?] Locally

[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]

Documentation changes

[Do the changes include any API documentation changes?]

  • Yes, this change contains documentation changes.
  • No.

Related Links

#221

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Security

Testing

Covered by internal visual regression tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo
fralongo requested a review from a team as a code owner September 5, 2022 07:25
@fralongo
fralongo requested review from michaeldowseza and removed request for a team September 5, 2022 07:25
@codecov

codecov Bot commented Sep 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #242 (cad3ca1) into main (d4e70a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         555      555           
  Lines       15708    15708           
  Branches     4295     4295           
=======================================
  Hits        14560    14560           
  Misses       1067     1067           
  Partials       81       81           
Impacted Files Coverage Δ
src/code-editor/index.tsx 87.40% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fralongo
fralongo force-pushed the fralongo-code-editor-radius-fix branch from 6c1cdfd to cad3ca1 Compare September 5, 2022 13:16
@fralongo
fralongo merged commit d710d07 into main Sep 5, 2022
@fralongo
fralongo deleted the fralongo-code-editor-radius-fix branch September 5, 2022 16:06
fralongo added a commit that referenced this pull request Sep 7, 2022
fralongo added a commit that referenced this pull request Sep 7, 2022
katiegeorge pushed a commit that referenced this pull request Sep 12, 2022
katiegeorge pushed a commit that referenced this pull request Nov 1, 2022
rubencarvalho pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants