Fix property methods that don't return values

[cnicholas]

Priority: Critical

Multiple property methods in AnalysisSpecification and AnalysisDataSet reference self.attribute but don't return it, so they always return None.

Affected Code

In AnalysisSpecification (lines 603-622):

def data_prep_output_cols(self) -> list:
    self.data_prep_output_cols  # Missing return!

def analysis_output_cols(self) -> list:
    self.analysis_output_cols  # Missing return!

def has_grouping(self) -> bool:
    self.has_grouping  # Missing return!

In AnalysisDataSet (lines 1240-1256):

def sampling_design_state(self) -> int:
    self.sampling_design_state  # Missing return!

def raw_dataset(self) -> pd.DataFrame:
    self.raw_dataset  # Missing return!

Impact

• Critical bug: Properties always return None
• Broken API
• Will cause runtime errors if anyone uses these properties

Fix

Add return statements to all property methods or remove the property decorators since they're already instance attributes.

Files

• analysis_dataset.py