fix(ci): skip changeset-check on the version-packages PR#23
Conversation
The changesets bot's "chore: version packages" PR (branch changeset-release/main) consumes changesets — it deletes the .md files and bumps versions, adding none. The changeset-check job counts only added/modified .changeset/*.md files (--diff-filter=AM), so it always reported 0 and failed on that PR (e.g. #22), even though the PR is correct by construction. Guard the job so it runs for normal PRs but skips the bot's version PR: `github.head_ref != 'changeset-release/main'`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds a changeset markdown file explaining an internal CI change to skip the changeset-check job on the changesets bot's "version packages" PR. However, the actual CI workflow file changes are missing from the pull request, leaving the implementation incomplete.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| Internal CI change (no version bump): skip the `changeset-check` job on the | ||
| changesets bot's "version packages" PR (`changeset-release/main`). That PR | ||
| consumes (deletes) changesets rather than adding them, so the check counted 0 | ||
| added/modified changeset files and always failed. |
There was a problem hiding this comment.
The actual CI workflow file changes (such as adding the github.head_ref != 'changeset-release/main' guard) are missing from this pull request. Currently, the only modified file is this changeset markdown file. Please commit and push the workflow changes to this branch to complete the implementation.
There was a problem hiding this comment.
This looks like a misread — the workflow change is included. The PR touches 2 files: .github/workflows/ci.yml (adds the changeset-check guard) and this changeset. You can see it in the diff, and the changeset-check job is already passing green on this PR. No action needed.
🤖 Generated by /pr-fixup command
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to avoid running the changeset-check job on the Changesets bot’s auto-generated “chore: version packages” pull requests (branch changeset-release/main), where changesets are consumed rather than added.
Changes:
- Skip
changeset-checkwhen the PR head branch ischangeset-release/main. - Add an empty changeset documenting the CI-only behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds a job-level if: guard to skip changeset-check on the Changesets release PR branch. |
.changeset/skip-changeset-check-on-version-pr.md |
Empty changeset describing the internal CI change (no version bump). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The PR successfully addresses the requirement to skip the changeset-check job on automated versioning PRs, preventing false failures. Codacy analysis indicates the changes are up to standards. The primary technical recommendation is to generalize the branch check to ensure compatibility with multi-branch release strategies, as the current implementation is restricted to the 'main' branch.
Test suggestions
- Verify
changeset-checkjob is skipped whengithub.head_refis 'changeset-release/main' - Verify
changeset-checkjob executes whengithub.head_refis not 'changeset-release/main'
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify `changeset-check` job is skipped when `github.head_ref` is 'changeset-release/main'
2. Verify `changeset-check` job executes when `github.head_ref` is not 'changeset-release/main'
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| if: github.event_name == 'pull_request' | ||
| # Skip the changesets bot's "version packages" PR: it consumes (deletes) | ||
| # changesets rather than adding them, so it would always fail this check. | ||
| if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main' |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: The branch name check is restricted to 'main'. If you use other base branches for releases, this check will fail. Using a prefix check handles all release branches.
| if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main' | |
| if: github.event_name == 'pull_request' && !startsWith(github.head_ref, 'changeset-release/') |
There was a problem hiding this comment.
Good call — adopted. Switched to !startsWith(github.head_ref, 'changeset-release/') so it covers the bot's branch for any base branch, not just main.
🤖 Generated by /pr-fixup command
Per review (Codacy): the changesets bot branches as changeset-release/<baseBranch>, so use !startsWith(github.head_ref, 'changeset-release/') instead of an exact match on 'changeset-release/main'. Same behavior for this repo today, but robust to other base branches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
changeset-release/main) consumes changesets — it deletes the.changeset/*.mdfiles and bumps versions, adding none. Thechangeset-checkjob counts only added/modified changeset files (git diff --diff-filter=AM), so it always reported0and failed on that PR (most recently chore: version packages #22), even though the version PR is correct by construction.github.head_ref != 'changeset-release/main'.This is a CI-only change, so the changeset is empty (no version bump).
Test plan
changeset-checkruns and passes (it's a normal PR with a changeset).changeset-checkis skipped instead of failing red.🤖 Generated with Claude Code