Skip to content

Terminate task#38

Merged
ognjenkatic merged 10 commits into
masterfrom
feat/master/terminate-task
Sep 2, 2022
Merged

Terminate task#38
ognjenkatic merged 10 commits into
masterfrom
feat/master/terminate-task

Conversation

@boma96

@boma96 boma96 commented Aug 25, 2022

Copy link
Copy Markdown
Collaborator

Added support for terminate task

builder.AddTask(
                wf => wf.Terminate,
                wf => new() { TerminationStatus = TerminationStatus.Failed, WorkflowOutput = new { Property = "Test" } }
            );

@boma96
boma96 requested a review from ognjenkatic August 25, 2022 12:13
ognjenkatic
ognjenkatic requested changes Aug 25, 2022
View reviewed changes

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion

Comment thread src/ConductorSharp.Engine/Model/TerminateTaskModel.cs Outdated
@boma96
boma96 requested a review from ognjenkatic August 26, 2022 07:48
ognjenkatic
ognjenkatic approved these changes Sep 2, 2022
View reviewed changes

@ognjenkatic ognjenkatic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ognjenkatic
ognjenkatic merged commit 6a2e6a7 into master Sep 2, 2022
@ognjenkatic
ognjenkatic deleted the feat/master/terminate-task branch September 2, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ognjenkatic ognjenkatic ognjenkatic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boma96 @ognjenkatic