Expand logging context#57
Merged
Merged
Conversation
Collaborator
Author
|
This PR also removes the context logging from the old request/response logging behavior, so the user can decide which to use. |
boma96
reviewed
Sep 30, 2022
boma96
previously requested changes
Sep 30, 2022
boma96
left a comment
Collaborator
There was a problem hiding this comment.
Some minor change to consider
ognjenkatic
dismissed
boma96’s stale review
October 3, 2022 15:58
This change request has been fulfilled. Discarding just so i can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new behavior which enriches the logger with conductor context. This means we will automatically have the conductor context information available in all loggers inside that scope. This also means we will be able to filter logs by workflow/task properties and corelate events much easier.