User story
As a GitLab user, I would like to have some feature equivalent to GitHub annotations, so that during code review I can see new issues in source code which Code PushUp detected.
Research
GitLab CI/CD supports Code Quality reports, which are tightly integrated in the MR user interface.
The Code Quality report format maps nicely to our Issue model. The only non-trivial field is the fingerprint, which serves to uniquely identify the violation. We could take inspiration from eslint-formatter-gitlab here, which hashes the relative file path, rule ID and message.
Acceptance criteria
User story
As a GitLab user, I would like to have some feature equivalent to GitHub annotations, so that during code review I can see new issues in source code which Code PushUp detected.
Research
GitLab CI/CD supports Code Quality reports, which are tightly integrated in the MR user interface.
The Code Quality report format maps nicely to our
Issuemodel. The only non-trivial field is thefingerprint, which serves to uniquely identify the violation. We could take inspiration fromeslint-formatter-gitlabhere, which hashes the relative file path, rule ID and message.Acceptance criteria
code-pushup.ymltemplate creates a code quality report artifactdetectNewIssuesis disabled, no such report is created