refactor: Remove Participants tab from Rooms (#155) - #158
Merged
Merged
Conversation
The Participants tab was unreliable: uteke-serve /room/stats returns a
participant COUNT but not the participant_namespaces list, so the tab
fell back to deriving agents from the 50 most-recent room memories and
undercounted (sidebar showed N, tab showed 1). Rather than depend on an
upstream uteke-serve change, drop the tab entirely — simpler UX.
Removed: Participant interface, loadParticipants/getParticipants, the
participants $effect, roomStatsData/participantsLoading state, the tab
button + content, and the participant CSS. The sidebar room-card still
shows the authoritative server participant_count ("N agents").
Closes #155
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-cli · BYOK · MIT |
With the Participants tab gone, the room-card "N agents" count had no drill-down behind it. Remove it (and the now-unused participant_count field on UtekeRoom) for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Participants tab from the Rooms view (-98 lines).
The tab was unreliable: uteke-serve
/room/statsreturns a participant count but not theparticipant_namespaceslist, sogetParticipants()fell back to deriving agents from the 50 most-recent room memories and undercounted (sidebar "N agents" vs tab "1"). Rather than depend on an upstream uteke-serve change, the tab is dropped for a simpler UX.Removed
ParticipantinterfaceloadParticipants()/getParticipants()+ their$effectroomStatsData/participantsLoadingstate.participant-*)Kept
participant_count("N agents") — that count is correct.participant_countfield stays on theUtekeRoominterface.Validation
svelte-check: 0 errors (warnings 36 → 34, unused participant CSS removed)vitest: 60 passed (7 files)npm run build: ✓Closes #155.