fix: Connections tab not rendered — ConnectionManager wired into SettingsModal - #86
Merged
Merged
Conversation
…ngsModal PR #84 added ConnectionManager into SettingsView.svelte, but SettingsView is orphan dead code (never imported). App renders SettingsModal, whose tabs were corin/general/data/agents only — so the Connections UI never appeared. - Add 'connections' tab to SettingsModal - Render ConnectionManager via async import under that tab - Delete orphan SettingsView.svelte (no references anywhere)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #84 / #85
Bug
The Connections UI (from #84 Remote Connection Manager) was never visible.
ConnectionManager.sveltewas embedded inSettingsView.svelte, butSettingsViewis orphan dead code — no file imports it. The app rendersSettingsModal.svelte, whose tabs werecorin/general/data/agentsonly. Result: no way to reach the Connections section from the UI.
Fix
connectionstab toSettingsModal.svelte.ConnectionManager.svelteunder that tab via async import (lazy chunk).SettingsView.svelte(zero references) to prevent future confusion.Validation
npm run buildclean.