Skip to content

companion(node): bump base node 22 → 24 LTS (0.0.12) - #14

Merged
AntoineToussaint merged 1 commit into
mainfrom
codefly-node24-companion
Jun 13, 2026
Merged

companion(node): bump base node 22 → 24 LTS (0.0.12)#14
AntoineToussaint merged 1 commit into
mainfrom
codefly-node24-companion

Conversation

@AntoineToussaint

@AntoineToussaint AntoineToussaint commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Bumps the Node runtime companion base from node:22.12.0-alpine3.21 to node:24.16.0-alpine3.22 (Node 24 LTS) and the companion version 0.0.11 → 0.0.12.

Coordinated with the nextjs agent (NodeVersion 22→24 + codeflydev/node:0.0.12) and saas-starter's frontend Dockerfile (node:24-alpine), pushed separately.

⚠️ Requires publishing codeflydev/node:0.0.12 (via the companion build/push flow on the codeflydev registry) before nextjs runtime can pull it.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime environment to version 24.16.0-alpine, replacing the previous 22.12.0-alpine version. This brings the latest security patches and performance improvements to the development environment.

FROM node:22.12.0-alpine3.21 → node:24.16.0-alpine3.22 (Node 24 LTS). Bumps the
companion version to 0.0.12 so consumers (the nextjs agent) pin the new image.

NOTE: codeflydev/node:0.0.12 must be published (build_companion.sh +
push_companion.sh, logged into the codeflydev registry) for nextjs runtime to
pull it — the release/companion-publish flow handles this on merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@slopbuster

slopbuster Bot commented Jun 13, 2026

Copy link
Copy Markdown

💳 Subscription Required

codefly-dev has used all free reviews this month.

Subscribe to continue

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the Node companion container image from Alpine 22.12.0-alpine3.21 to 24.16.0-alpine3.22. The Dockerfile base image reference and version-pinning comments are updated, the metadata version is incremented, and the build script documentation reference is synchronized with the new image tag.

Changes

Node Companion Image Update

Layer / File(s) Summary
Node companion image version bump
companions/node/Dockerfile, companions/node/info.codefly.yaml, companions/scripts/build_companions.sh
Dockerfile base image pinned to node:24.16.0-alpine3.22, metadata version incremented to 0.0.12, and build script documentation updated to reference the new Node/Alpine tag.

🎯 1 (Trivial) | ⏱️ ~3 minutes

A rabbit hops through the version tree,
From Node twenty-two to twenty-four we see,
Alpine sips its newest brew with care,
Companions now run lighter through the air! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading the Node companion from version 22 to 24 LTS and bumping the version to 0.0.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codefly-node24-companion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
companions/node/info.codefly.yaml (1)

1-1: 💤 Low value

Consider whether the version bump should reflect the major Node upgrade.

The companion version is incremented from 0.0.11 to 0.0.12 (patch-level), while the underlying Node runtime jumps from 22.x to 24.x (major version). If companion versions follow semantic versioning and are intended to signal breaking changes or major dependency shifts to consumers, a larger bump (e.g., 0.1.0 or 1.0.0) might better communicate the significance of the Node 24 upgrade.

However, if companion versioning is intentionally decoupled from Node versioning, the current patch increment may be appropriate per your project's policy.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@companions/node/info.codefly.yaml` at line 1, The companion's version was
bumped only from 0.0.11 to 0.0.12 while the Node runtime jumped from 22.x to
24.x; decide whether this is a breaking/minor compatibility change and either
(a) update the version field currently set as "version: 0.0.12" to an
appropriate semver that reflects the Node upgrade (e.g., "version: 0.1.0" for a
minor or "version: 1.0.0" for a major breaking change), or (b) keep the patch
bump but add a short policy note in the repository/docs stating that companion
versioning is intentionally decoupled from Node runtime versions so consumers
understand the choice.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@companions/node/info.codefly.yaml`:
- Line 1: The companion's version was bumped only from 0.0.11 to 0.0.12 while
the Node runtime jumped from 22.x to 24.x; decide whether this is a
breaking/minor compatibility change and either (a) update the version field
currently set as "version: 0.0.12" to an appropriate semver that reflects the
Node upgrade (e.g., "version: 0.1.0" for a minor or "version: 1.0.0" for a major
breaking change), or (b) keep the patch bump but add a short policy note in the
repository/docs stating that companion versioning is intentionally decoupled
from Node runtime versions so consumers understand the choice.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1c1fd23d-c5a7-4e02-bf7c-a7a82b6f31c9

📥 Commits

Reviewing files that changed from the base of the PR and between c8ee8d5 and 041cd29.

📒 Files selected for processing (3)
  • companions/node/Dockerfile
  • companions/node/info.codefly.yaml
  • companions/scripts/build_companions.sh

@AntoineToussaint
AntoineToussaint merged commit 363e4c2 into main Jun 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant