chore: pin proto companion Go to 1.27 via nix flake (#343) - #344
Merged
antoinetoussaint-byte merged 2 commits intoAug 23, 2026
Conversation
Pin the runtime `go` in companions/proto/flake.nix protoTools to go_1_27 (the locked nixpkgs resolves it to 1.27.0), commit a flake.lock so the Nix-built image is reproducible instead of floating on nixos-unstable, and bump the legacy --force-docker Dockerfile builder stage to golang:1.27-alpine for consistency. info.codefly.yaml stays at 0.0.12: the 0.0.13 republish is blocked on an amd64 builder and cli#456, and bumping now would make `codefly companion verify` point at an unpublished tag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The flake header contrasted Nix's content-hash pinning against the Dockerfile's best-effort pin, naming `golang:1.26-alpine`. The builder stage was just bumped to `golang:1.27-alpine`, so that reference was left factually wrong by the same change. Align the comment with the Dockerfile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #343.
Summary
companions/proto/flake.nix(NixdockerTools), so its Go comes from nixpkgs — not the legacy--force-dockerDockerfile. nixpkgs' defaultgostill resolves to 1.26.x, so pinprotoToolstogo_1_27to match the rest of the Go 1.27 audit (Go companion image still on Go 1.26 after v0.3.8 Go 1.27 bump (breaks container builds of go 1.27.0 services) #341/fix: bump Go companion image to Go 1.27 (#341) #342). Only swagger'sgofmtuses thisgo; proto never runsgo build, so this is a cosmetic-consistency bump, not a correctness fix.flake.lockso the image is actually reproducible instead of floating onnixos-unstable. The locked nixpkgs resolvesgo_1_27to1.27.0.--force-dockerDockerfile builder stage togolang:1.27-alpinefor consistency.info.codefly.yamlintentionally stays at0.0.12: the0.0.13republish ofcodeflydev/protois blocked on an amd64 builder (proto is amd64-only and can't be assembled from an aarch64 nix builder) and on cli#456 fixingcodefly companion publish. Bumping the version now would makecodefly companion verifypoint at an unpublished tag. The republish is a follow-up once those land.Test plan
nix flake lockgeneratesflake.lock(pins nixpkgs + flake-utils).nix evalagainst the locked nixpkgs:go_1_27.version→1.27.0(vs defaultgo→1.26.5).nix eval .#packages.x86_64-linux.dockerImage.drvPathevaluates cleanly withgo_1_27.codeflydev/proto:0.0.13on amd64 CI (deferred — see blocker above).