chore: tracking placeholder for linux/arm64 service agents (Refs #346) - #348
Merged
antoinetoussaint-byte merged 2 commits intoAug 23, 2026
Conversation
Core's downloader already resolves agent assets via runtime.GOOS/GOARCH, so it targets service-<name>_<version>_linux_arm64.tar.gz on arm64 Linux without change. No CI host builds on linux/arm64, so the existing host-platform test never exercises that asset name. Extract downloadURLForPlatform so the platform is a parameter, and add a regression test asserting core requests the exact linux_arm64 asset the service-* release matrices must publish. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…act (#346)" This reverts the no-op change from 9ba33c9. Self-review found the added test tautological: the download path has no arch-dependent branching (GitHubAsset and the extracted helper are plain fmt.Sprintf), so asserting linux/arm64 specifically catches nothing the existing host-platform test doesn't — os and arch are interpolated identically regardless of value. The downloadURLForPlatform extraction existed only to feed that tautology, so it goes with it. Core's downloader is already architecture-agnostic (runtime.GOOS/GOARCH), so it needs no change for arm64 Linux. The actionable work for #346 lives in the service-* release matrices and the cli pins, not this repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Closing as no-op. Reverted to empty after self-review: core's downloader is already architecture-agnostic, so there was no non-tautological core-side change to make for #346. The actionable work (service-* releases + cli pins) is cross-repo — tracked in #346, which stays open. See the issue comment for the redirect. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #346. (Deliberately not
Closes— the actionable work is cross-repo; this PR must not auto-close the tracking issue.)Status: tracking placeholder — empty diff
Core needs no code change for linux/arm64. Its agent downloader and every store (OCI/HTTP/Nix) already resolve assets via
runtime.GOOS/runtime.GOARCH, and the CLI self-updater already handlesEM_AARCH64/CpuArm64. On an arm64 Linux host, core already requestsservice-<name>_<version>_linux_arm64.tar.gz— the asset just 404s today because publishers don't emit it yet.An earlier revision added a test to "pin" this, but the download path has no arch-dependent branching (
GitHubAssetis a plainfmt.Sprintf), so the assertion was tautological and caught nothing the existing host-platform test doesn't. It was reverted; the branch now carries no diff and exists only to track #346 from this repo.Remaining work (all cross-repo, none in
core)linux-arm64goreleaser build + cut a release in eachservice-*repo:service-go,service-python,service-nextjs,service-rust,service-swift,service-generic.pkg/sourceworkspace/source.goif versions roll.--platform linux/amd64companion pin in clicompanions.yamlonce agents publish arm64.Close this PR once the releases land, or repurpose the branch if a genuine core-side change surfaces.