fix(installer): report the requested unsupported platform - #21
Open
xujiantop-crypto wants to merge 1 commit into
Open
fix(installer): report the requested unsupported platform#21xujiantop-crypto wants to merge 1 commit into
xujiantop-crypto wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ensureEngine()receives an unsupported platform or architecture override, it selects assets using that override but reports the host platform in the error. For example, requestinglinux-riscv64on Windows x64 reportsno CodeGraph engine is published for win32-x64.Resolve the platform and architecture once, using the existing defaults for omitted values, and use them for both asset selection and the error message. Add regression coverage for three unsupported pairs and each partial override, including rejection before the install directory is created.
Validation:
main(489ccf1); the existing installer checks pass.npm testinmcp-packageexits successfully on Windows x64 with Node.js 24.10.0. All installer checks pass. The existing wrapper argument suite reportsSKIPbecause its stub engine was not used on this host.git diff --checkpasses.