Skip to content

fix(installer): report the requested unsupported platform - #21

Open
xujiantop-crypto wants to merge 1 commit into
codegraph-ai:mainfrom
xujiantop-crypto:fix/installer-unsupported-platform
Open

fix(installer): report the requested unsupported platform#21
xujiantop-crypto wants to merge 1 commit into
codegraph-ai:mainfrom
xujiantop-crypto:fix/installer-unsupported-platform

Conversation

@xujiantop-crypto

Copy link
Copy Markdown

When ensureEngine() receives an unsupported platform or architecture override, it selects assets using that override but reports the host platform in the error. For example, requesting linux-riscv64 on Windows x64 reports no CodeGraph engine is published for win32-x64.

Resolve the platform and architecture once, using the existing defaults for omitted values, and use them for both asset selection and the error message. Add regression coverage for three unsupported pairs and each partial override, including rejection before the install directory is created.

Validation:

  • Before the fix, the five new error-message assertions fail against main (489ccf1); the existing installer checks pass.
  • After the fix, npm test in mcp-package exits successfully on Windows x64 with Node.js 24.10.0. All installer checks pass. The existing wrapper argument suite reports SKIP because its stub engine was not used on this host.
  • git diff --check passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant