fix: throw Postgre query errors with warnings disabled (#6913) - #10573
Open
wakqasahmed wants to merge 2 commits into
Open
wakqasahmed wants to merge 2 commits into
wakqasahmed wants to merge 2 commits into
Conversation
wakqasahmed
commented
Sep 19, 2026
wakqasahmed
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed 6d7297a against #6913. No actionable issues found.
The new failure path honors DBDebug, and BaseConnection::query() preserves default transaction exception suppression and transException(true) rollback behavior. The server error is captured before rollback can overwrite it. The regression restores error_reporting() in finally and uses the existing test database setup. The change is compatible with PHP 8.2.
Remaining validation: I did not rerun runtime tests during this review. The new regression covers warnings-disabled DBDebug=true outside transactions; warnings-disabled DBDebug=false and transaction cases have no additional regression tests. CI for this revision is still pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseExceptionwhen Postgre'spg_query()returnsfalsewithDBDebugenabled, even if PHP warnings are disabled.Test plan
developand passes with the fix against a disposable Postgre test database.BadQueryTest.php(3 tests, 4 assertions).git diff --check.