chore: update code to 1.70.2#5485
Conversation
|
@fritterhoff thank you! do the patches need to be updated/refreshed? |
|
Nope. No changes required. |
Codecov Report
@@ Coverage Diff @@
## main #5485 +/- ##
=======================================
Coverage ? 72.44%
=======================================
Files ? 30
Lines ? 1673
Branches ? 366
=======================================
Hits ? 1212
Misses ? 398
Partials ? 63 Continue to review full report at Codecov.
|
|
Amazing! I'll checkout locally and test. Also requesting review from @code-asher - once we both ✅, we can merge. |
We know this test is flakey. #5481 should reduce that a bit. |
|
All looks good. I did notice a weird flash of the terminal prompt but I don't know if that's related to Screen.Recording.2022-08-22.at.10.07.26.AM.mov |
|
I am not seeing my prompt doing that (using Bash). My guess is it is either ZSH or the predictive output but probably unrelated to this PR. |
|
Actually maybe they did change something...when I run ZSH there is a slight flash but not with 4.6.0. Weird. |
|
Ah nevermind I see it on 4.6.0 as well, just at a different frequency. |
Fixes #5470
How to test locally