refactor: drop db migration patch#5519
Conversation
Drop migration code since it's been 6 months since 4.0.2 and we no longer need this. See: #5482 (comment)
| - sendErrorTelemetry: this.sendErrorTelemetry, | ||
| - }; | ||
| - this.impl = this._register(new BaseTelemetryService(config, configurationService, productService)); | ||
| - |
There was a problem hiding this comment.
@code-asher I refreshed all the patches. Does this look okay to you?
There was a problem hiding this comment.
Looks like the blocks shifted a little, probably due to using a different diff algorithm, but I think it should be fine! Looks like I am using patience (you can see what you have by running git config diff.algorithm in the code-server repo).
There was a problem hiding this comment.
Uh...looks like I'm not using one? 😅 Reminds me of when I first started at Coder and Anmol/I were using different algorithms.
Okay I will leave as is for now then and merge this!
There was a problem hiding this comment.
Ah that probably means it is using the default (myers).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5519 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 30 30
Lines 1673 1673
Branches 366 366
=======================================
Hits 1212 1212
Misses 398 398
Partials 63 63 Continue to review full report at Codecov.
|
This was supposed to be removed in #5519 Looks like I didn't update the series or actually delete the patch.
* chore: update Code to 1.72.2 * chore: refresh integration patch * chore: refresh base-path * chore: refresh proposed-api patch * chore: refresh marketplace patch * chore: refresh webview patch * chore: refresh disable-builtin patch * chore: refresh logout, update-check patches * chor: refresh proxy-uri patch * fix: delete unique-db patch This was supposed to be removed in #5519 Looks like I didn't update the series or actually delete the patch. * fix: drop log-level patch This was merged upstream! * chore: refresh local-storage patch * chore: refresh service-worker patch * chore: refresh sourcemaps patch * chore: refresh disable-downloads patch * chore: refresh telemetry patch * chore: refresh language patch * chore: refresh cli-window-open patch * Revert "fix: delete unique-db patch" This reverts commit ca0506c. * fixup!: rm extra spaces integration patch * fixup: space * fixup! update unique-db patch * fixup!: update hash in webview patch * fixup! update marketplace patch * fixup!: remove comma
This drops the patch and also the tests (which were flakey and our longest running e2e tests).
Fixes #5482