fix(api-types): drop org_id + project_id from ConnectionRow - #13
Merged
Conversation
…eal wire shape Follow-up to #12. The backend's serializeConnection() strips both fields before responding; any runtime parse of a real /v1/connections response would have rejected it. Test updated to the real shape. Discovered during enterprise adoption (codespar-enterprise#41) — the fix landed on the api-types branch after #12 was merged, so it needs to ship as its own PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionRowSchemaclaimedorg_idandproject_id, but the backend'sserializeConnection()strips both before sending. Any runtime.parse()of a real/v1/connectionsresponse would have failed.Why it matters
Discovered while adopting the schema in codespar-enterprise#41 — the fix was written but landed on the
feat/api-types-packagebranch after #12 was squash-merged. This PR brings main to the correct shape before publishing@codespar/api-types@0.1.0to npm.Test plan
npm run build -w @codespar/api-types— cleannpm run test -w @codespar/api-types— 14/14 pass🤖 Generated with Claude Code