fix(ci): waiver obsoleto e achado proprio, nao "esqueceu de bumpar" - #134
Merged
Conversation
Found by running the guard through the case it will actually meet: someone
bumps @codespar/sdk to close core#131 and leaves the waiver behind.
The per-package line was right ("the waiver is stale, delete it") but the
::error:: annotation that GitHub surfaces said "1 package(s) changed without
a version bump: @codespar/sdk@0.12.0" — about a package that had just been
bumped correctly. A reader who sees only the annotation is sent to fix the
one thing that is already right.
Stale waivers now carry status "stale-waiver" and their own summary line.
Both still fail the build; they no longer claim to be the same finding, and
the two fixes are opposites: one wants a version, the other wants a deleted
line.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcao pequena no guarda que entrou no #133, achada rodando ele contra o caso que ele vai encontrar de verdade: alguem bumpa o
@codespar/sdkpara fechar a core#131 e esquece o waiver.O defeito
Cenario reproduzido, guarda do
mainem4f6d21c:A linha por pacote esta certa. A anotacao
::error::, que e o que o GitHub mostra em cima do job e no diff, diz "changed without a version bump" sobre um pacote que acabou de ser bumpado corretamente. Quem le so a anotacao e mandado consertar exatamente a unica coisa que ja estava certa.Sao duas falhas diferentes com consertos opostos: uma quer uma versao, a outra quer uma linha deletada. Estavam saindo com a mesma etiqueta.
O que mudou
Waiver obsoleto passa a ter status proprio,
stale-waiver, e linha de resumo propria. As duas continuam reprovando o build.Controles
Teste novo:
does not tell a correctly bumped package that it forgot to bump. Ele exige que os dois status difiram e que a mensagem do bumpado nao contenhabump the version.Nao-vacuidade, por mutacao: revertendo
stale-waiverparadriftno guarda, 3 testes morrem, incluindo o novo.Restaurado: 11/11 passam. O guarda completo no estado do
maincontinua saindo 0, com os mesmos 2 waived e 12identical.Comportamento inalterado nos outros caminhos, medido: drift real continua
drifte continua reprovando; waiver removido sem bump continua reprovando como drift; bump com waiver removido passa.Nao fecha issue. Ajusta o guarda do #133.