Conversation
…nnections connections() returns [] on a failed or empty backend response. [].every() is vacuously true, so the waitForConnections gate broke on the first poll and createSession resolved while zero servers were connected — the opposite of the manageConnections.waitForConnections contract. Guard with conns.length > 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
loop() had no tests. Covers happy path, dynamic params(prevResults), when() skips, abortOnError true/false, thrown-error retry, linear and exponential backoff, and the zero-step / all-skipped edge cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks again, Andre — quality PR, easy to review. Verified locally:
One tiny note for future PRs: a couple of test comments reference Merging. |
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sdk): waitForConnections treats empty/failed connections as connectedIn
packages/core,createSession'smanageConnections.waitForConnectionsgate breaks as soon asconnections().every(c => c.connected)is true. Butconnections()returns[]on a failed or empty backend response, and[].every(...)is vacuouslytrue— so the gate resolves on the first poll with zero servers connected, the opposite of whatwaitForConnectionspromises. Guarded withconns.length > 0.The Python SDK already guards this (
_async_session.py:if conns and all(...)), so this also restores TS/Python parity.test(sdk): loop() had no testsloop()(the "Complete Loop" orchestration) had zero coverage. Adds tests for: happy path, dynamicparams(prevResults),when()skips,abortOnErrortrue/false, thrown-error retry, linear vs exponential backoff, and the zero-step / all-skipped edge cases.No wire-contract change.
npm test+tsc --noEmitgreen forpackages/core.