Add fixed-calibration THIN_PRISM_FISHEYE support for Caspar BA - #4657
Draft
DuVogel87 wants to merge 4 commits into
Draft
Add fixed-calibration THIN_PRISM_FISHEYE support for Caspar BA#4657DuVogel87 wants to merge 4 commits into
DuVogel87 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds draft
THIN_PRISM_FISHEYEsupport to the Caspar bundle-adjustment backend for narrow fixed-calibration rig BA cases.Supported scope in this PR:
THIN_PRISM_FISHEYEsensor_from_rigpoints3DUnsupported THIN_PRISM combinations fail explicitly instead of silently skipping observations.
Important scope note: this draft does not claim incremental mapper / local BA support for
THIN_PRISM_FISHEYEyet. The incremental mapper can exercise additional local-BA gauge and fixed-variable combinations that are outside the narrow generated factor set in this PR.Motivation
Caspar currently supports only a limited set of camera models. This PR adds fixed-calibration
THIN_PRISM_FISHEYErig factors for calibrated fisheye rigs.The first use case is points-only BA after reconstruction. The second use case is fixed-intrinsics pose+point BA, which is closer to full BA while still avoiding variable intrinsics and sensor-from-rig refinement.
Implementation notes
COLMAP parameter order:
Caspar split constant layout:
Projection follows COLMAP
THIN_PRISM_FISHEYEbehavior:theta = atan(r)mapping,uu,vv,The branch currently contains four logical commits:
BriefReport()and an explicit unsupported THIN_PRISM three-point gauge test.Tests
f32:
cmake -S . -B build-minimal-pr-v3-cuda-ceres-tests -GNinja \ -DCMAKE_BUILD_TYPE=Release \ -DCUDA_ENABLED=ON \ -DCMAKE_CUDA_ARCHITECTURES=86 \ -DCASPAR_ENABLED=ON \ -DCASPAR_USE_DOUBLE=OFF \ -DTESTS_ENABLED=ON \ -DGUI_ENABLED=OFF \ -DCeres_DIR=/home/ubu/dev/src/ceres-cuda/install/lib/cmake/Ceres cmake --build build-minimal-pr-v3-cuda-ceres-tests --target bundle_adjustment_caspar_test -j 10 ./build-minimal-pr-v3-cuda-ceres-tests/src/colmap/estimators/bundle_adjustment_caspar_testResult: 22/22 passed.
f64 THIN_PRISM-specific tests:
Result: 5/5 THIN_PRISM tests passed.
A previous full f64 local run still had two non-THIN merged-calibration failures in this environment, so this remains a draft for review rather than ready-to-merge.
Limitations
This PR intentionally does not add:
THIN_PRISM_FISHEYE,refine_sensor_from_rig,This is a narrow fixed-calibration implementation, not a complete Caspar THIN_PRISM feature set.