Skip to content

fix(angular): render nested custom components - #330

Open
tomatotomata wants to merge 1 commit into
comarkdown:mainfrom
tomatotomata:codex/fix-angular-nested-components-294
Open

fix(angular): render nested custom components#330
tomatotomata wants to merge 1 commit into
comarkdown:mainfrom
tomatotomata:codex/fix-angular-nested-components-294

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary

Resolves #294.

Nested custom Angular components were initialized by assigning directly to the child component instance. That bypasses Angular input change detection, so nested components were created but rendered empty. This changes the recursive renderer to use ComponentRef.setInput for all child inputs.

The same path now catches component creation and initialization errors, logs the component tag, destroys a partially-created view, and continues rendering later siblings.

Validation

  • Added focused regression coverage for nested input binding.
  • Added coverage that a failed custom component is logged without stopping later siblings.
  • git diff --check passes.

The full package test command is left to CI because this checkout cannot materialize the repository's Windows-invalid packages/comark/SPEC/common-mark/horizontal-rule-3*.md fixture path.

Let me know what you think.

@tomatotomata
tomatotomata requested a review from farnabaz as a code owner August 4, 2026 23:28
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

@tomatotomata is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@comark/angular: custom components inside lists, tables or other components render nothing

1 participant