fix(angular): render nested custom components - #330
Open
tomatotomata wants to merge 1 commit into
Open
Conversation
|
@tomatotomata is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #294.
Nested custom Angular components were initialized by assigning directly to the child component instance. That bypasses Angular input change detection, so nested components were created but rendered empty. This changes the recursive renderer to use
ComponentRef.setInputfor all child inputs.The same path now catches component creation and initialization errors, logs the component tag, destroys a partially-created view, and continues rendering later siblings.
Validation
git diff --checkpasses.The full package test command is left to CI because this checkout cannot materialize the repository's Windows-invalid
packages/comark/SPEC/common-mark/horizontal-rule-3*.mdfixture path.Let me know what you think.