Multilanguage badges - #25244
Merged
Merged
Multilanguage badges#25244
Conversation
sshane
force-pushed
the
multilanguage-badge
branch
from
July 22, 2022 07:41
ebe3432 to
1fa46f6
Compare
sshane
force-pushed
the
multilanguage-badge
branch
from
July 22, 2022 08:04
1fda7eb to
ebf1bba
Compare
sshane
marked this pull request as ready for review
July 22, 2022 10:01
Collaborator
Author
|
@adeebshihadeh we need something like https://pypi.org/project/svgutils/ if you want to concatenate svgs and do the proper newline adjustments once we have more languages that would be too wide for the README width, are you okay with that? Adjusting with raw python or an XML library is do-able but I feel it'd be a lot of code (need to adjust main document size dynamically, add padding, move over badges to proper x, newline, etc) |
sshane
force-pushed
the
multilanguage-badge
branch
from
July 22, 2022 20:34
cc8781d to
e4f15a7
Compare
Collaborator
Author
|
Will merge as-is now, I'll think about automatically adding or combining the svgs when we add our next language. Right now the script outputs the badges to copy+paste: |
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
* Test badge * fix? * Test * debug * debug * debug * debug * debug * debug * debug * try this * need to build * a minute for what * download and commit test badge * get dynamically * fix * Add to readme * force push * should work * one step * Update badge * draft * clean up * remove these * one line is fine * Adding badges will have to be manual, but that should be fine * cause error * continue on error * hope this doesn't delete the badges * ugh, allow-failures would be so nice * whoops * yep need this * do this * now try a push * clean up * rm line * need this * see if this works * orange * does this work? * ? * do dis * needs to be global? * cool, this works cool, this works * run only on master * add back workflows * remove that * sorting * sorting * print badge markdown * it is bytes though? * run once more * revert * looks nicer * strange * no decimals * run again run once more * nice workflow_dispatch * only run on a schedule and remove error handling * make links absolute * adjust badge text old-commit-hash: 9ab1c49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can just use the prebuilt docker once this is in master
Preview:
View README here.